295343 - Remote Server URL in 'Create New Calendar' Fails Silently, should alert/warn

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Josh]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

When you input an invalid URL for REMOTE SERVER URL when creating a calendar, no
error message is shown and the program simply tosses your settings when you
click OK.

Reproducible: Always

Steps to Reproduce:
1.Create a new calendar
2.Input an invalid url 
3.Go back to edit your calendar to see if it saved your settings

Actual Results:  
Remote URL was not saved

Expected Results:  
Given me an error right away, saying "hey I only support http:// and ftp://"
or something like that.

It just would be nice if the program gave error messages when an error occured
rather then failing silently and leaving the user dumbfounded.

Comment 1

[Joey Minta]

Confirming, with some additions to the summary.  I did a bit of testing on
20050505-nightrat and this bug still exists, in a slightly modified form, there.

Steps to reproduce: (trunk)
1.) Open the New Calendar wizard.
2.) Choose 'Remote'
3.) Enter a URL with an invalid beginning (ie, just type 'foo')
4.) Finish the wizard.

Actual Results:
Wizard closes, but calendar is not created (never appears in the calendar list,
even after restart.)

Expected Results:
The wizard should warn that an invalid URL has been entered, and should not finish.

Reproducable: Always

Status: NEW
Component: Front-End
OS/Hardware: ALL

Comment 2

[Joey Minta]

Attachment: disallow bad urls

This patch prevents the wizard from advancing or the calendarProperties dialog
from closing with 'OK' when the url enterred isn't acceptable.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 189526 [details] [diff] [review]
disallow bad urls

>diff -prU 8 mozilla/calendar/resources/content/calendarCreation.js patch/content/calendarCreation.js
>+function checkURL() {
>+    checkRequired();

I don't think you should call checkRequired here. Make the caller do that, or
do it the other way around: make checkRequired call checkURL. (because the url
is a required field, but not all required fields are url's)
r=mvl if you change that.

Comment 4

[Joey Minta]

Attachment: disallow bad urls v2

Now checkRequired() calls checkURL().  If there's no value, it fails in
checkRequired().  If there is a value, it must pass checkURL()

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 190149 [details] [diff] [review]
disallow bad urls v2

>+        if( canAdvance && document.getElementById("calendar-uri").value )

minor nit: The prefered style is: if (foo), with spaces outside the brackets.

r=mvl

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in