295355 - Minimizing TB window bypasses playing Windows minimization sound

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Mike Cowperthwaite]

TB 1.0.2, TB 1.0+0515, Win2K

When I minimize a Thunderbird window, I notice at least two things don't happen 
that should:
1) Whichever program was active before TB was activated does not become 
reactivated when TB is minimized.
2) The sound that I have Windows play for window minimize, does not play.

The first is more of a problem.  I minimize TB, and go to start typing in the 
editor window that was open behind it, and... where are my keystrokes going?  
Oh, I have to click the editor now.

The problem happens with the 3-pane window, with the compose window, and with 
the Address Book.  Not a problem with Firefox 1.0.4 or my recent 1.8b2 suite 
build.

This is minor, but it is annoying -- and TB must be doing something special to 
bypass the default Windows behaviors.

Comment 1

[Gunnar Wagenknecht]

It works on Windows XP.

Comment 2

[Mike Cowperthwaite]

I just discovered this isn't only TB, now.  Seamonkey 1.0a and 1.1a and (an old) Deer Park (1.9a1-1003) all exhibit this same problem.

(In reply to comment #1)
> It works on Windows XP.

I can't confirm that, only have W2K here.

Comment 3

[Phil Hannent]

I can confirm that I see it on my Windows XP SP2 machine, using Thunderbird 1.5 RC1.

Comment 4

[Gunnar Wagenknecht]

(In reply to comment #3)
> I can confirm that I see it on my Windows XP SP2 machine, using Thunderbird 1.5
> RC1.

Interesting. I see the problematic behavior also on my work notebook. However, I could swear I heared the minimize sound on my machine at home (also running XP).

Comment 5

[Rich Parker]

I'm also seeing issue #2 (no minimize sound) with Firefox 1.5 and Thunderbird 1.5 in Windows 98 SE.  The maximize, restore up, and restore down sounds are working.  Other apps handle the minimize sound without any trouble.

Comment 6

[zug_treno]

*** Bug 330116 has been marked as a duplicate of this bug. ***

Comment 7

[Patrick Mannion]

I see this problem also - XP SP2 with all patches, and (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1)

Comment 8

[Mike Cowperthwaite]

See bug 300689 -- almost all of the problems in this bug have been fixed on the trunk, and it just got approved for TB 2.0 and the other Gecko 1.8.1 releases.  (Thanks again, James!)

The one behavior that I know of that is still missing on minimize is the playing of the minimize sound, so I'm repurposing this bug for that.  If anyone notices other 'normal' minimize behaviors not occurring, please note them here.

Also, the other bug points out a workaround: setting the preference
  config.trim_on_minimize
to 'true' will revert to default Windows minimization behavior.  The reason this pref defaults to 'false' is: the default behavior includes "trimming the working set" -- that is, freeing up memory where TB's operating code is stored so it can be used by other programs.  If those memory pages do get reused by another program, then on maximizing, they have to be reloaded from disk, which causes a sometimes-sizeable delay while maximizing.  (xref bug 76831)

Comment 9

[James Ross]

Attachment: Play minimize sound when using trim-hack

API compatibility: all implemented in Windows 95 and Windows NT 3.1.

Comment 10

[Mike Cowperthwaite]

Cool!
Does the minimize sound apply for WinCE?

Comment 11

[James Ross]

Comment on attachment 233675 [details] [diff] [review]
Play minimize sound when using trim-hack

Good point Mike; I think it doesn't. #ifdef glory coming soon to a patch near you.

Comment 12

[James Ross]

Attachment: This time with #ifdef glory

The PlaySound call is already inside an #ifndef WINCE, so the only change is the extra header is now wrapped.

Comment 13

[Ere Maijala (slow)]

Comment on attachment 233683 [details] [diff] [review]
This time with #ifdef glory

Until the day we don't need the hack anymore...
r=emaijala

Comment 14

[HyperHacker]

I've used WinXP SP2, SP1 and no SP and not once had Firefox play the Minimize sound. Problem 1 also seems to be related to a tab problem: Switching tabs doesn't switch keyboard focus until I click the page in the new tab. If I were to switch to another open tab while typing this, and continue typing, I'd still be typing in this now-hidden textbox until I clicked something on the page in the other tab.

Comment 15

[Mike Cowperthwaite]

Any chance of getting this patch checked in sometime soon?  I'd love to get it into TB 2.0 but I'm worried it's a bit late for that.

Comment 19

[Nickolay_Ponomarev]

Sivler, any reason this shouldn't be checked in? (This doesn't apply cleanly, but the merge fix appears to be trivial.)

Comment 20

[James Ross]

The patch has been in all my (Firefox, SeaMonkey and XULRunner) builds, which I always use (never touch the mozilla.org builds for those 3), and it's yet to cause any problems. I don't see any reason not to check it in.

Comment 21

[James Ross]

Checked in --> FIXED.

Comment 22

[Mike Cowperthwaite]

V fixed with TB 3apre1-0527, Win2K.  Thanks!!