295375 - Random crash (can't figure out how to reproduce)

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect, P1)

Description

[Ludovic Hirlimann [:Usul]]

I'm seeing Camino crash. I have not yet foudna  way to reprodcue it.
Talkback ID TB6092900X. Crash log coming up.

Comment 1

[Ludovic Hirlimann [:Usul]]

Attachment: Crash log

Comment 2

[Simon Fraser [no longer active]]

This is probably something in my site icon code.

Comment 3

[Simon Fraser [no longer active]]

Steps to reproduce:
1. show history in a browser window.
2. close that window
3. in new window, nagivate to site with favicon.

NSZombieEnabled reveals:

2005-05-24 18:52:41.423 Camino[485] *** *** Selector 'siteIconLoaded:' sent to
dealloced instance 0xd5678f0 of class HistoryDataSource.
Break at '-[_NSZombie methodSignatureForSelector:]' to debug.
2005-05-24 18:52:41.423 Camino[485] Exception raised during posting of
notification.  Ignored.  exception: *** Selector 'siteIconLoaded:' sent to
dealloced instance 0xd5678f0 of class HistoryDataSource.
Break at '-[_NSZombie methodSignatureForSelector:]' to debug.

Comment 4

[Simon Fraser [no longer active]]

Fix:
Index: HistoryDataSource.mm
===================================================================
RCS file: /cvsroot/mozilla/camino/src/history/HistoryDataSource.mm,v
retrieving revision 1.34
diff -u -r1.34 HistoryDataSource.mm
--- HistoryDataSource.mm	23 May 2005 03:36:08 -0000	1.34
+++ HistoryDataSource.mm	25 May 2005 01:54:52 -0000
@@ -679,6 +679,8 @@
 
 - (void)cleanupHistory
 {
+  [[NSNotificationCenter defaultCenter] removeObserver:self];
+
   if (mHistoryObserver)
   {
     nsCOMPtr<nsIHistoryItems> historyItems = do_QueryInterface(mGlobalHistory);


Checked in.

Comment 5

[Mike Pinkerton (not reading bugmail)]

sweet. yeah i was hitting this too. good catch.