295405 - Problems setting default news, mail and feed settings on Windows

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Scott MacGregor]

Sometimes the default app settings in the general options panel don't work. i.e.
you make it the default client, hit ok, open the dialog again and the box is not
checked like it should.

Comment 1

[Scott MacGregor]

Attachment: the fix

the new preferences APIs expect everything in the dialog to be a real
preference. but this isn't true for the default app settings which are based on
registery keys and not preferences. So the APIs end up creating dummy prefs
(mail.checkDefaultMail, mail.checkDefaultNews, etc.). The fix is to initialize
these dummy prefs every time the dialog is opened to the values we read out of
the registry. Now when the user changes the check box for the pref, the pref
APIs will always call our on write methods which sets the setting back in the
windows registry.

Note: You may need to delete any mail.checkDefault* prefs from your prefs.js
file in your profile to get things working correctly again.

Comment 2

[David :Bienvenu]

Comment on attachment 184440 [details] [diff] [review]
the fix

thx, Scott, that was driving me batty.

Comment 3

[Scott MacGregor]

Attachment: better fix