rename internal names for tooltip objects

RESOLVED FIXED

Status

Calendar
Sunbird Only
--
trivial
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: gekacheka, Assigned: Mostafa Hosseini)

Tracking

Details

Attachments

(1 attachment)

13.53 KB, patch
Michiel van Leeuwen (email: mvl+moz@)
: first-review+
Details | Diff | Splinter Review
(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: trunk

The internal names for the tool tip objects defined in calendar.xul are misleading:
  eventTooltip
  taskTooltip
  eventTreeListTooltip

"eventTooltip" sounds as if it should be used for events anywhere (WRONG).
"taskTooltip" sounds as if it should be used for tasks anywhere (WRONG).
These two names sound as if they work in similar/parallel ways (WRONG).

However, in fact the tool tips are specialized for each parent window and the
methods used to fill the data, not for the contents.  

The "eventTooltip" is actually used for all the grid views, and should be used
when mousing over any occurrence box of an event or task in any grid view.
Therefore, rename
  eventTooltip --> gridOccurrenceTooltip

The "taskTooltip" is used only for the task tree, and the "eventTreeListToolTip"
is used only for the event tree.  These two are similar/parallel, so should have
similar names.  So rename

  taskToolTip          --> taskTreeToolTip
  eventTreeListToolTip --> eventTreeToolTip

(May want to change the purpose of the trees in the future.
 For example, there have been requests to be able to view tasks and events
together in a sorted list.   So the two may become the "current" tree and the
"filter" tree.  But that's for the future, this is about naming them for what
they do now.)

Reproducible: Always
(Reporter)

Comment 1

13 years ago
Created attachment 184447 [details] [diff] [review]
rename tooltips patch

(patch -l -p 2 -i file.patch)

Rename tooltips internally
  eventTooltip --> gridOccurrenceTooltip
  taskTooltip	       --> taskTreeTooltip
  eventTreeListTooltip --> eventTreeTooltip
(Reporter)

Updated

13 years ago
Blocks: 295418
(Reporter)

Comment 2

13 years ago
Comment on attachment 184447 [details] [diff] [review]
rename tooltips patch

(split from bug 295146 as suggested.  thanks for reviews!)
Attachment #184447 - Flags: first-review?(mvl)
Comment on attachment 184447 [details] [diff] [review]
rename tooltips patch

r=mvl
Attachment #184447 - Flags: first-review?(mvl) → first-review+
checked in
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

13 years ago
QA Contact: gurganbl → sunbird
You need to log in before you can comment on or make changes to this bug.