Closed
Bug 295424
Opened 20 years ago
Closed 20 years ago
share code to set up tooltip content for unifinder, unifinderToDo
Categories
(Calendar :: Sunbird Only, defect)
Calendar
Sunbird Only
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gekacheka, Assigned: mostafah)
References
Details
Attachments
(1 file)
|
4.94 KB,
patch
|
mvl
:
first-review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: trunk
Cleanup:
Rename changeTooltipForTask/Event to onMouseOverTask/Event
to make clearer they are for event handlers.
Move code from unifinderj.js and unifinderToDo.js to mouseoverPreviews.js
Pass tooltip as parameter, avoid some document.getElementById calls.
Reproducible: Always
Steps to Reproduce:(patch -l -p 2 -i file.patch)
Clean up:
Renamed ChangeToolTip... to onMouseOver... to make clearer
that they are event handlers when reading the js files.
Pass tooltip so it doesn't have to be looked up with document.getEltById.
Moved from unifinder.js and unifinderToDo.js to mouseoverPreviews.js
Pulled out common code to setTooltipContent
(preparation to add more in other bugs).
testing:
all three tooltips (grid, event list, task list) still work.Comment on attachment 184462 [details] [diff] [review] Clean up unifinder/unifinderToDo onMouseOver, share code (split from bug 295146 as suggested. thanks!)
Attachment #184462 -
Flags: first-review?(mvl)
Comment 4•20 years ago
|
||
Comment on attachment 184462 [details] [diff] [review] Clean up unifinder/unifinderToDo onMouseOver, share code r=mvl
Attachment #184462 -
Flags: first-review?(mvl) → first-review+
Comment 5•20 years ago
|
||
patch checked in
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•19 years ago
|
QA Contact: gurganbl → sunbird
You need to log in
before you can comment on or make changes to this bug.
Description
•