295429 - Favicon (site icon) appears on a site that fails if user icon has been cached

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Samuel Sidler (old account; do not CC)]

If a user, say, goes to mozilla.org, it's icon gets saved into cache. If then, a
user returns to mozilla.org while they do not have internet access, with the new
error pages, the request will fail, show an error page, and show the
favicon/site icon for the failed page which was cached the first time he was online.

Make sense?...

To reproduce:
1. Use a recent nightly with error pages turned on.
2. Visit Mozilla.org and see the mozilla.org favicon.
3. Turn off your internet access.
4. Attempt to visit mozilla.org again.

Results:
The mozilla.org favicon appears next to the URL.

Expected results:
Blank/no favicon as the appearance of the icon implies the page succeeded.

Comment 1

[Simon Fraser [no longer active]]

Hrm, I guess I need to get a load status in OnLocationChanged.

Comment 2

[Simon Fraser [no longer active]]

Fixed. When the nsIRequest in OnLocationChange has a failure status, we set the
site icon to a little yellow triangle.