295512 - Error pages broken

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Frank Wein [:mcsmurf]]

To reproduce:
(0. Fetch trunk build, not required i think, but it seems error pages are
already broken for a longer time now)
1. Set startpage to http://www.nonexistingdomainblabla.com
or
1. Open address book and right click on a entry and click on Instant Message
2. Observe that you get a error about undefined entity (loadError.label)

Comment 1

[Frank Wein [:mcsmurf]]

BTW: I tried to find out if this is a regression, not possible, before todays
build it only displays nothing (only a white area) instead of a error page (or a
error).

Comment 2

[Scott MacGregor]

actually I think this may be a regression from the locale repackaging work? Then
again maybe not, it looks like it should be getting built.

The entity file in question is:

netError.dtd

Comment 3

[Frank Wein [:mcsmurf]]

Note netError.dtd is being shipped, in en-US.jar with path locale\en-US\global,
so that seems correct to me. en-US.manifest also includes a line
locale global en-US jar:en-US.jar!/locale/en-US/global/

Comment 4

[Frank Wein [:mcsmurf]]

Ok, the problem is res/html/xhtml11.dtd is stripped from the build. Now i found
two solutions: Either add this file to Thunderbird or modify netError.xhtml a
bit. I need to contact biesi and see if my second solution is ok.

Comment 5

[Frank Wein [:mcsmurf]]

Attachment: Patch

Just includes res/dtd/ again (the solution with changing error pages might
cause problems).

Comment 6

[Scott MacGregor]

Comment on attachment 184859 [details] [diff] [review]
Patch

once the tree opens for 1.1a2, just go ahead and check this in.

Comment 7

[Frank Wein [:mcsmurf]]

Patch checked in, i'll resolve as fixed when i'm done testing a build with this 
fix.

Comment 8

[Frank Wein [:mcsmurf]]

Ok fixed