295520 - Page Info Security tab broken for pages with frames

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Pawel Worach]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050525 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050525 Firefox/1.0+

The page info security tab is blank and the "View" button does nothing.
This only happens for pages with frames such as the URL above and even this
bug-entry page that has an iframe with the bug list.
If you click in the frame and do "Show only this frame" the security tab looks good.
No error in the JS console.
Also double clicking the padlock in the status bar does not open the "Security"
tab automatically but the "General" tab, don't know if it's related to this
but it works on non-framed pages.

Reproducible: Always

Steps to Reproduce:
1. Go to a SSL page with frames such as
https://eredovisning.plusgirot.se/ddrint/nordea/LoginFrame.jsp
https://www.soft.nordea.se/soft/index.html or
https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox
2. Right click on page, click "View Page Info" in context menu.
3. Click Security tab.

Actual Results:  
The security tab is blank and the "View" button does not work.

Expected Results:  
Security tab displaying cipher information and "View" button displaying
certificate details.

Comment 1

[Pawel Worach]

Attachment: Screenshot of broken Security tab

Comment 2

[Pawel Worach]

Win32 installer trunk builds tested and result:

2005-05-19-07-trunk OK
2005-05-21-07-trunk OK
<no closer match found with nightly builds>
2005-05-21-22-trunk Broken
2005-05-22-15-trunk Broken
2005-05-23-06-trunk Broken

Comment 3

[Steve England [:stevee]]

Regression range from comment 2
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-05-21+06%3A00%3A00&maxdate=2005-05-21+23%3A00%3A00&cvsroot=%2Fcvsroot
I'm guessing bug 294984 might have possibley caused this.

Comment 4

[Steve England [:stevee]]

WFM Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050521
Firefox/1.0+ ID:2005052104
BKN Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050521
Firefox/1.0+ ID:2005052110

Comment 5

[:Gavin Sharp [email: [e-mail]]]

I'm thinking the wrappers bug is a more likely candidate, the parser shouldn't
have an effect on something like this.

Comment 6

[Steve England [:stevee]]

New range
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-05-21+06%3A00%3A00&maxdate=2005-05-21+11%3A00%3A00&cvsroot=%2Fcvsroot
exonerating bug 294984

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Javascript console error:
Error: aWindow.frames[i] has no properties
Source File: chrome://browser/content/pageInfo.js
Line: 432

That line:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/pageInfo.js&mark=472#466

Comment 8

[Johnny Stenback (:jst)]

Attachment: Define properties by index when resolved so that callers see the properties before getting the value.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 184554 [details] [diff] [review]
Define properties by index when resolved so that callers see the properties before getting the value.

>Index: dom/src/base/nsDOMClassInfo.cpp

>+      // A numeric property accessed and the numeric proerty is a

s/proerty/property/

> nsWindowSH::NewResolve(nsIXPConnectWrappedNative *wrapper, JSContext 

>+      // If we're resolving a numeric property. Treat that as if

Comma before "treat", please -- the part up to "property" is not a sentence.

>+        // A numeric property accessed and the numeric proerty is a

"property"

>+        // child frame. Define a property for this index.

r+sr=bzbarsky

Comment 10

[Johnny Stenback (:jst)]

Fixed.