295522 - Auto-complete truncates urls

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Graeme Porteous]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050521 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050521 Camino/0.8+

In the location bar type 't', Camino's auto-complete feature will truncates any
urls for domains starting with 't' to ttp://www.t-domain.com/

Reproducible: Always

Steps to Reproduce:
1. Have a bookmark or visit a domain starting with 't' e.g.:
http://www.textdrive.com/
2. Type 't' into the location bar.
3. Press down arrow key until you reach http://www.textdrive.com/
Actual Results:  
The location bar will show ttp://www.textdrive.com/ So pressing return loads the
wrong url.

Expected Results:  
Should show/load correct url.

This also effects 'p' and 's' (and probably more) p://www.p-domain.com/ and
s://www.secure-domian.com/ respectively.

Using the mouse to click suggested auto-complete items will load the correct
address.

Comment 1

[Graeme Porteous]

Attachment: Screenshot Showing Truncated URL

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #0)
> The location bar will show ttp://www.textdrive.com/ So pressing return loads the
> wrong url.

This WFM.  It briefly shows ttp://textdrive.com but loads the full, correct URL,
http://textdrive.com.

Are you sure you didn't accidentally make an error at some point and end up with
an autocomplete/history entry that *is* ttp://textdrive.com?  (E.g., sometimes I
type "fo" (to autocomplete forums.mozillazine.org) and hit return before the
full autocomplete entry comes up, and I end up with an autocomplete entry of
"fo" that always pops up first.)



> 
> Expected Results:  
> Should show/load correct url.
> 
> This also effects 'p' and 's' (and probably more) p://www.p-domain.com/ and
> s://www.secure-domian.com/ respectively.
> 
> Using the mouse to click suggested auto-complete items will load the correct
> address.

Comment 3

[Mike Pinkerton (not reading bugmail)]

yeah, this loads the correct url for me as well, though the url is displayed as
you say. weird.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

See bug 202992 (Toolkit) and bug 122862 (SM), where I linked to:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/autocomplete/src/nsAutoCompleteController.cpp&rev=1.29&mark=1146-1151#1141

Looks like Camino has its own autocomplete impl though, so don't know how much
use that would be.

Comment 5

[Mike Pinkerton (not reading bugmail)]

right, that code isn't used in camino at all.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #5)
> right, that code isn't used in camino at all.

I know that, I simply figured it might lead to finding the equivalent code in
Camino's implementation. That's all :).

Comment 7

[Graeme Porteous]

Okay your right. It does go to the right url - what was I doing yesterday... I
must of been trying to edit the url after it'd displayed wrong, ugh.

So the location bar updates when return is hit, if it hasn't already been
edited. Correct behavior, but originally displays wrong.

Comment 8

[Simon Fraser [no longer active]]

This is a bug in the url bar autocomplete code; when we stuff the selected URL
into the url bar, we look at the typed chars, see where those occur in the
selected URL, and insert everything after that. That's why it only occurs with
the characters h, t or p (and maybe s), because those occur in "http(s)".

Comment 9

[Simon Fraser [no longer active]]

The bug is here:
http://lxr.mozilla.org/mozilla/source/camino/src/browser/AutoCompleteTextField.mm

My guess is that it's always been there.

Comment 10

[Simon Fraser [no longer active]]

Attachment: Patch to ignore chars in the scheme part of the url

Comment 11

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 184593 [details] [diff] [review]
Patch to ignore chars in the scheme part of the url

r=pink

Comment 12

[Simon Fraser [no longer active]]

Checked in.