295596 - Regression: <a><li>foo</li></a> no longer linked

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Laurent G.]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050523 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050523 Firefox/1.0+

Some old local docs contain html code with inversed "a" and "li" tags.
Instead of
li a ... /a /li
it has
a li ... /li /a
Firefox 1.0.4 can render both OK while Deer Park renders as link just the logical
(at least in my opinion) one, the first.


Reproducible: Always

Steps to Reproduce:
1. Create a simple page with a list of links where "a" and "li" are in reverse
containment ( "li" inside "a")
2. Try to follow the link
3.

Actual Results:  
Text rendered, not as link

Expected Results:  
Text rendered, as link. Or was it just a hidden feature from Firefox, so far ?

How do one quotes code here ?

Comment 1

[djpohly]

Pass: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050519
Firefox/1.0+

Fail: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520
Firefox/1.0+

Probably fallout from the 2005-05-19 09:36 checkin for bug 38174.

--> HTML: Parser

Comment 2

[djpohly]

Attachment: testcase

Reporter:
The best way to give HTML examples is to attach a minimal testcase to the bug.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

For no reason that I understand, we close transient styles that cannot contain
the container that we're trying to open them for. This is incorrect for <li>
because of cases like this, where we're trying to open styles that the author
wanted to apply to the children of the <li>.

This is, IMO, the safest solution. I disable the weird behavior for <li>, but
not for anything else, so there should be no side effects.

Comment 4

[Laurent G.]

> Reporter:
> The best way to give HTML examples is to attach a minimal testcase to the bug.

OK, noted. Thanks.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 184602 [details] [diff] [review]
patch v1

sr=jst

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 184602 [details] [diff] [review]
patch v1

This is a safe fix for a recent regression.

Comment 7

[Mike Shaver (:shaver emeritus)]

Comment on attachment 184602 [details] [diff] [review]
patch v1

a=shaver

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked in. Thanks for the nice testcase.

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

*** Bug 297913 has been marked as a duplicate of this bug. ***