295642 - cannot attach additional attachments

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[sairuh (rarely reading bugmail)]

found using 200505260x-trunk tbird builds on Windows and Mac OS X.

cannot attach additional files to a message.

1. open a new message compose window.
2. click the Attach button.
3. attach more than 1 file.
4. click the Attach button again.
5. attach one or more files.

results: the files from step 5 aren't attached.

Tracy has a good workaround for this.

Comment 1

[Tracy Walker [:tracy]]

note: It is attaching two or more files in one filepicker session, using
ctrl+click, that is causing the bug.

the workaround is arduous

-With sairuhs steps, break one account. (once an account has experienced the bug
it will be broken for subsequent mail compose/attach file attempts)
workaround:
-then switch to another mail account
-compose an email and attach only one file at a time.
-cancel or send the email
-return to the broken account and perform attachments in mail composition one
file at a time.

Comment 2

[Scott MacGregor]

Actually, the attachments are indeed added to the message. And if you send the
message the attachments will go out.

But for some reason the attachments aren't showing up in the attachment list
box! I see us calling listbox.appendChild(attachment) to tell the toolkit to
show the attachment but then nothing gets displayed. If you ask the list box how
many children are in the listbox it gives us the correct number.

Comment 3

[Tracy Walker [:tracy]]

looks like a dupe of 285624

Comment 4

[Scott MacGregor]

Attachment: possible fix

This fixes the problem for me. But i was only seeing this bug if I added some
attachments and then deleted them. The problem was happening whenver we had to
re-hide the attachment bucket and then had to show it again later. 

Cause:

I was hiding the attachment bucket using the hidden property which causes the
content to get torn down. After removing the last attachment, we'd hide the
attachment bucket using .hidden. After it was made visible again, attempts to
append items to the list box always failed.

The fix is to used .collapse instead of .hidden. Collapse is much friendlier.
The only required part of the this change is the swich from hidden to collapse.
While I was here, I modified our iteraction with the list box to use listbox
APIs instead of DOM element APIs. So changes to use getRowCount, appendItem,
etc. aren't required per say.

Comment 5

[David :Bienvenu]

Comment on attachment 184641 [details] [diff] [review]
possible fix

seems OK to me...

Comment 6

[sairuh (rarely reading bugmail)]

*** Bug 285624 has been marked as a duplicate of this bug. ***

Comment 7

[Scott MacGregor]

Chris, can you test this again on tomorrow's builds? 

Comment 8

[Tracy Walker [:tracy]]

verified with Windows thunderbird trunk build from 05/27