Closed Bug 29566 Opened 24 years ago Closed 20 years ago

Images in links along with text get a double outline focus

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Future

People

(Reporter: jst, Unassigned)

References

Details

(Keywords: testcase, Whiteboard: [fixinhand])

Attachments

(1 file)

Due to the following style rule in html.css

:link:focus, :visited:focus, :out-of-date:focus,
:link:focus img, :visited:focus img, :out-of-date:focus img {
   outline: 1px dotted black;
 }

links with focus get an 1px wide black dotted outline. That's cool but this
style rule also makes images within a link get an outline, to see an example of
this go to the above URL and click (or right click) the "Share Prices" link,
then *both* the link and the little green triangle in the link get outlines.

I propose that the the style rule should be changed to:

:link:focus, :visited:focus, :out-of-date:focus {
   outline: 1px dotted black;
 }
Pierre, cvs blame attributes the change to you so I'm reassigning the bug
Assignee: troy → pierre
Are the outlines drawn correctly if the rule is removed?  The images should be
outlined when tabbing through.  (This could depend on revisions of the outline
code to work more like the way CSS2 describes...)
Images (ones that are inside an <A> tag) are outlined when tabbing on a page
with such links (like the URL above), I can't say if the outline is correctly
drawn or not but that's IMO outside the scope of this bug.
Assigning to Waqar: 1/3 of Pierre's NEW bugs to help reduce his doomage factor
Assignee: pierre → waqar
Reassigned back to me these bugs that shouldn't have left my list.
Assignee: waqar → pierre
Links are no longer outlined in current builds even though the declarations in 
html.css did not change: Rod may know why.

Also, could you run MacIE5 and have a look at the page above? Click on one the 
links and appreciate how the outline is drawn to encompass the 2 elements in a 
single outline.
Assignee: pierre → rods
reassign to M16
Target Milestone: --- → M16
mass-move to M16
Moving out by executive order.
Target Milestone: M16 → M17
core layout "outline" issues
Assignee: rods → karnaze
Marking remind. This will not make release 1.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → REMIND
Target Milestone: M17 → M20
I think this bug should be marked as a dup of bug 32818.
No, it seems quite different to me.
The "little green triangle is gone". Anyone know what's going on here?
(REMIND is deprecated, reopening).
Status: RESOLVED → REOPENED
Resolution: REMIND → ---
Attached file testcase
The rules in html.css are now:

*|*:-moz-any-link:focus {
  -moz-outline: 1px dotted invert;
}

*|*:-moz-any-link:focus img {
  -moz-outline: 1px dotted invert;
}

The combination of rules causes a double outline along the bottom of an image
inside a link that contains both text and an image.  Removing the image rule
would make focus invisible for links that are just images, so we can't do that.

One way to fix this bug is to make the link's outline go around the image it
contains (bug 133165, required for CSS2), and then remove the extra rule in
html.css.
reassigning to Marc (we miss you), this is not a table bug, and I doubt that
this bug will be fixed as long as it is on karnazes list. 
Assignee: karnaze → attinasi
Status: REOPENED → NEW
Target Milestone: --- → Future
Depends on: 133165
->default. Marking "fixinhand" per Jesse's comments about removing a rule.
Assignee: attinasi → other
QA Contact: petersen → ian
Summary: Outlines on images within links (with outline)... → Images in links along with text get a double outline focus
Whiteboard: [fixinhand]
Keywords: testcase
The testcase works for me now, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a4) Gecko/20040925
Firefox/0.9.1+

I think this bug was fixed by the fix for bug 133165.
Fixed by bug 133165
Status: NEW → RESOLVED
Closed: 24 years ago20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: