295660 - String leaks loading documents from W3C XSL Test Suite

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect)

Description

[Bob Clary [:bc] (inactive)]

0. Configure/Install Spider
   see <http://bclary.com/2004/07/10/mozilla-spiders#links>, especially the 
   Spider Help page. You can run Spider as an HTML, Remote XUL, or chrome XUL 
   app.
1. Load Spider from URL or from chrome.
2. Log into test.bclary.com 
   Contact me for user id/password if you wish to access the tests. These are 
   locked down for the moment until I am in a better position to make them 
   public.
3. Click Run.
   Take a break. This loads over 2000 documents.

If you start Firefox/Spider from the command line you can redirect STDOUT/STDERR
to a file. Example log
<http://test.bclary.com/results/2005-05-26-firefox-trunk-02.log> (12.7M).

xslts: nsStringStats
xslts:  => mAllocCount:        3644480
xslts:  => mReallocCount:       286478
xslts:  => mFreeCount:         3644478  --  LEAKED 2 !!!
xslts:  => mShareCount:        3309915
xslts:  => mAdoptCount:         186863
xslts:  => mAdoptFreeCount:     138127  --  LEAKED 48736 !!!

Running the top 69 web site homepages gets a similar results, but worse on the
mFreeCount leaks.

top-sites: nsStringStats
top-sites:  => mAllocCount:         284754
top-sites:  => mReallocCount:        58648
top-sites:  => mFreeCount:          281303  --  LEAKED 3451 !!!
top-sites:  => mShareCount:         267771
top-sites:  => mAdoptCount:          36182
top-sites:  => mAdoptFreeCount:      33851  --  LEAKED 2331 !!!

To run the top site's test, use
<http://test.bclary.com/tests/mozilla.org/top-sites/test-sites.html> instead of
the XSL Test Suite URL

Comment 1

[Bob Clary [:bc] (inactive)]

I forgot to include the XML Test Suite since it had been crashing, but for some
reason didn't crash this last time even though Bug 292717 has not been checked
in. For reference, it also leaks like a sieve:

xmlts: nsStringStats
xmlts:  => mAllocCount:        2751522
xmlts:  => mReallocCount:       271850
xmlts:  => mFreeCount:         2751484  --  LEAKED 38 !!!
xmlts:  => mShareCount:        2840875
xmlts:  => mAdoptCount:         373088
xmlts:  => mAdoptFreeCount:     272298  --  LEAKED 100790 !!!

Comment 2

[Boris Zbarsky [:bzbarsky]]

I tried poking around at this some, but there're just a lot of pages... a
minimal-ish testcase that reproducibly makes those numbers bigger within the
context of a single page would be great.

Comment 3

[Martijn Wargers (dead)]

Maybe this has something to do with bug 303163, the url testcase of that bug is
on the list at http://test.bclary.com/tests/mozilla.org/top-sites/test-sites.html

Comment 4

[Martijn Wargers (dead)]

Bob, is this still an issue, now that bug 303163 is fixed?

Comment 5

[jag (Peter Annema)]

Also see bug 336914 (mAdoptFreeCount not maintained correctly).

Comment 6

[Boris Zbarsky [:bzbarsky]]

Is this still a problem?  The url in the URL bar gives a 404.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

bc: ping

Any new links to what's failing here?

Comment 8

[Bob Clary [:bc] (inactive)]

i ran a refcnt enabled 1.9.2 build over the W3 XSL documents and found no leaks. -> WFM. I'll do the XML and DOMTS next.