295663 - Remove unused preferences update.app.* update.extensions.*

Status: RESOLVED WORKSFORME

(Firefox :: Settings UI, defect)

Description

[:Mook]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050520 Firefox/1.0+

The prefs update.app.* and update.extensions.* are unused (the ones in use are
app.update.* and extensions.update.* instead).  This appears to be fallout from
aviary landing [1].  The only exception is update.extensions.enabled, which is
written in [2] but never read from.  (The corresponding pref,
extensions.update.enabled, is read from but never written to - but it looks like
it may be a hidden pref. [3] [4])

[1]
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/toolkit/mozapps/update/content&command=DIFF_FRAMESET&file=update.js&rev2=1.23&rev1=1.22
[2]
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/update/content/update.js#155
[3] http://lxr.mozilla.org/mozilla/search?string=extensions.update.enabled
[4] http://lxr.mozilla.org/mozilla/search?string=PREF_UPDATE_EXTENSIONS_ENABLE

Reproducible: Always

Steps to Reproduce:
1. open about:config
2. see update.app.* and update.extensions.* preferences
3. check LXR for usage
Actual Results:  
Prefs exist, but are never written to / read from.

Expected Results:  
Prefs used, or non-existent.

Tried looking for getBranch calls as well, nothing turned up.

update.js should be referencing either extensions.update.enabled or
extensions.update.autoUpdateEnabled.

Comment 1

[:Mook]

Attachment: Remove unused prefs

Did not touch the JS that sets the pref because I'm unsure what it's supposed
to do.

If this bug actually makes sense I'll file a parallel bug for Thunderbird and
Sunbird after this is fixed.

Comment 2

[:Mook]

Comment on attachment 184652 [details] [diff] [review]
Remove unused prefs

Was fixed as of firefox.js rv 1.49, sorry.