295683 - File > Import dialog should not be blank (does not show any option)

Status: RESOLVED FIXED

(Firefox :: Migration, defect, P2)

Description

[Federico Calboli]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

The "Import" section of the "File" menu does not show any otion and is therefore
unusable. Impossible to migrate HTML saved bookmarks. Hinders migration to Firefox.

Reproducible: Always

Steps to Reproduce:
1.Click on "Menu/File/Import"
2.Import does not show any option
3.

Actual Results:  
Impossible to use the Import features

Expected Results:  
be able to use Import features

Comment 1

[Jo Hermans]

Are you talking about 'File->Import' in the Bookmarks Window (to import
bookmarks), or the 'File->Import' in the main browser window (to import entire
profiles) ? See also bug 236304 (MacIE), bug 236300 (Safari), ... 

Comment 2

[Jon Kiehnau]

I'm using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7 and the Import Wizard is non-functional and unable to  import HTML saved bookmarks.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

As I understand it, this happens when the importer can't find any importable profile bits from IE, Opera, Safari and other browsers. When that happens, we should either throw up a "can't find anything to import" dialog, or ask the user to point us to the location of the thing they want to import (which is a harder problem, as it means that we'd need to support the importing of bookmark files, cookie directories, etc from a file browser ...)

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

*** Bug 267630 has been marked as a duplicate of this bug. ***

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

(I *think* that this is migration component ...)

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Implements the "throw up a 'can't find anything to import' dialog" solution. The migrator doesn't support importing files user specified files (other than bookmarks), and I don't think supporting that is worth the trouble. Suggestions for better wording are welcome, right now it's just "No migration sources could be found.". Will attach screenshot of what the dialog looks like when no sources are found. Since I can't actually reproduce this I had to fake it, so some real testing would be appreciated. It's also late so I'm going to look at this again tomorrow.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Attachment: screenshot

Maybe "Could not find anything to migrate", or something like that, instead of what's there?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 214815 [details]
screenshot

rip it to shreds! :)

Comment 9

[:Gavin Sharp [email: [e-mail]]]

I also tested this with:
window.openDialog("chrome://browser/content/migration/migration.xul", "migration", "modal,centerscreen,chrome,resizable=no", "opera", {QueryInterface: function(){}}, {QueryInterface: function(){}});

in the JS console, to ensure that the "engine to select" param still works.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 214815 [details]
screenshot

I'm debating asking you to point people to the bookmark importer in the bookmark manager, but that just seems awkward to me. I do understand the reporter's assumption that this import dialog would be the logical place to import bookmarks, but that sounds like a larger refactoring of the code/UI.

For now, though, could we get rid of the tecchie term "migration sources"?

Two string changes:

s/Import Settings and Data From/Unable to Import Settings and Data/

s/No migration sources could be found/No programs that contain bookmarks, history or password data could be found.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

*** Bug 305547 has been marked as a duplicate of this bug. ***

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch v2

(In reply to comment #10)
> (From update of attachment 214815 [details] [edit])
> I'm debating asking you to point people to the bookmark importer in the
> bookmark manager, but that just seems awkward to me. I do understand the
> reporter's assumption that this import dialog would be the logical place to
> import bookmarks, but that sounds like a larger refactoring of the code/UI.

Yeah, I think this is best dealt with seperately.

> For now, though, could we get rid of the tecchie term "migration sources"?
> s/No migration sources could be found/No programs that contain bookmarks,
> history or password data could be found.

done

> s/Import Settings and Data From/Unable to Import Settings and Data/

not done: can't change the pane's label dynamically. Beltzner said over IRC that this change was ok to drop, though.

Patch is the same as the previous one, except with the string change from above.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Checked in branch and trunk.

mozilla/browser/components/migration/content/migration.xul 	1.18.2.5
mozilla/browser/components/migration/content/migration.js 	1.22.2.8
mozilla/browser/locales/en-US/chrome/browser/migration/migration.dtd 	1.4.2.1

mozilla/browser/locales/en-US/chrome/browser/migration/migration.dtd 	1.5
mozilla/browser/components/migration/content/migration.xul 	1.23
mozilla/browser/components/migration/content/migration.js 	1.29