295721 - focused tabs in tabbox behaviour tweaks

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Mike Connor [:mconnor]]

GTK2's tab widget doesn't do anything useful with focus, so I figure the Windows
impl is probably the most familiar.

Basically, focus+arrows doesn't wrap on Windows, but does on OS X.  Also,
Home/End should work with this widget.

Comment 1

[Mike Connor [:mconnor]]

Attachment: patch

adds home/end keybindings, uppercases the VK_* bits for consistency with the
rest of the codebase, and disables arrow key wrapping on Windows/GTK2 (we could
flip this bit, I'm not married to the behaviour except where defined by the
native widgets).

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 184693 [details] [diff] [review]
patch

bah

Comment 3

[Mike Connor [:mconnor]]

Attachment: same patch, except use a field instead of a property

this should be good to go

Comment 4

[Asaf Romano (gone)]

Well, it seems that advanceSelectTab tries to support hidden tabs (although, it
doesn't work very well for me, in cz). However, selectNewTab by itself doesn't
check for the hidden attribute, this might break the VK_HOME/VK_END bindings
form this patch.

Comment 5

[Mike Connor [:mconnor]]

Attachment: more tweaks

match Mac/GTK/Windows tab widgets by focusing on mousedown instead of click.

make sure hidden tabs don't get focused by end/start keystrokes either by
making selectNewTab cycle forward (or backwards, if aFallbackDir is set to -1).


Known issues:
first-tab/last-tab are just plain broken without a fixed number of tabs (bug to
be filed)
beforeselected/afterselected don't work with hidden tabs

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 184874 [details] [diff] [review]
more tweaks

r=vladimir

The first tab/last tab stuff is broken currently anyway, and this should be a
usability/responsiveness improvement...

Comment 7

[Mike Shaver (:shaver emeritus)]

Comment on attachment 184874 [details] [diff] [review]
more tweaks

a=shaver

Comment 8

[Mike Connor [:mconnor]]

Checked in.

Comment 9

[Marc Boullet]

This patch breaks a lot of extensions which use advanceSelectedTab (AiO
gestures, mini-T, etc).
Adding an argument to advanveSelectedTab is OK as far as the old behaviour is
maintained when the corresponding parameter is missing. In your patch, it is
just the reverse since a missing aWrap will stop wrapping.

Comment 10

[Mike Connor [:mconnor]]

File a new bug requesting that the fallback be to wrap if aWrap != false, don't
reopen a bug.

Btw, minit probably breaks because I integrated the code into the core in a
checkin five minutes before this one...

Comment 11

[Marc Boullet]

OK. Filed bug 297171.

Comment 12

[Martijn Wargers (dead)]

*** Bug 293342 has been marked as a duplicate of this bug. ***

Comment 13

[Jesse Ruderman]

*** Bug 218146 has been marked as a duplicate of this bug. ***