295726 - Disable presence URL check

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Scott MacGregor]

It looks like we still have some residual code from the Netscape e-mail client
days in the address book which trys to resolve aim presence for any address book
card that has a screen name in it when you display that card.

We're currently pinging a server on oscar.aol.com to see if that person is online.

We should disable this for now so we aren't hitting this server without
informing the user. 

I'd still like to investigate presence support in Thunderbird for a variety of
IM clients (not just AOL) down the line, but we'll want UI for allowing a user
to turn it on and off.

Comment 1

[Scott MacGregor]

Attachment: the fix

if def's out the code for now

Comment 2

[Worcester12345]

(In reply to comment #0)
...
> I'd still like to investigate presence support in Thunderbird for a variety of
> IM clients (not just AOL) down the line, but we'll want UI for allowing a user
> to turn it on and off.

Is there an open bug for this which I can put a cc: on? Thanks

Comment 3

[Christoph Grether]

(In reply to comment #2)
> (In reply to comment #0)
> Is there an open bug for this which I can put a cc: on? Thanks
I guess it is Bug216214 IM only supports AIM - request: support other IM tools

Comment 4

[Mark Banner (:standard8)]

With trunk build (and I guess branch) version 1.6a1 (20050918), the presence
check still appears to happen. I guess the problem may be in:

http://lxr.mozilla.org/seamonkey/source/mail/components/addrbook/jar.mn

look at lines 2 and 22, abCardViewOverlay.js is preprocessed from
content/abCardViewOverlay.js on line 2 and then not processed from
/mailnews/addrbook/resources/content/abCardViewOverlay.js on line 22.

It looks like the second instance is overwriting the first. Therefore
Thunderbird is actually picking up the non-branched version of
abCardViewOverlay.js (I checked by unpacking my messenger.jar)

Comment 5

[Mark Banner (:standard8)]

Attachment: Include the correct file in the build.

This patch fixes the problem with including the mailnews abCardViewOverlay.js
as opposed to the thunderbird one. The differences in the files are:

SeaMonkey currently checks for aim presence (we have a bug on that), whereas
the Thunderbird version does not.
SeaMonkey also uses openTopWin for opening URLs whereas the Thunderbird version
uses launchExternalURL from nsIMessenger.

So I think Thunderbird will want to pick up this change.

Scott if you want the patch in the 1.8 branch, please set/request approval.

Comment 6

[Scott MacGregor]

Comment on attachment 197285 [details] [diff] [review]
Include the correct file in the build.

thanks mark.

lemme know if you need me to check this into the 1.8 branch.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 197285 [details] [diff] [review]
Include the correct file in the build.

Checked into trunck & branch.

Comment 8

[OstGote!]

Note: See Bug 309068 for Mailnews (SeaMonkey).