Closed Bug 295726 Opened 19 years ago Closed 19 years ago

Disable presence URL check

Categories

(Thunderbird :: Address Book, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird1.1

People

(Reporter: mscott, Assigned: mscott)

References

()

Details

(Keywords: fixed1.8)

Attachments

(2 files)

It looks like we still have some residual code from the Netscape e-mail client
days in the address book which trys to resolve aim presence for any address book
card that has a screen name in it when you display that card.

We're currently pinging a server on oscar.aol.com to see if that person is online.

We should disable this for now so we aren't hitting this server without
informing the user. 

I'd still like to investigate presence support in Thunderbird for a variety of
IM clients (not just AOL) down the line, but we'll want UI for allowing a user
to turn it on and off.
Attached patch the fixSplinter Review
if def's out the code for now
Attachment #184707 - Flags: superreview?(bienvenu)
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird1.1
Attachment #184707 - Flags: superreview?(bienvenu) → superreview+
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
(In reply to comment #0)
...
> I'd still like to investigate presence support in Thunderbird for a variety of
> IM clients (not just AOL) down the line, but we'll want UI for allowing a user
> to turn it on and off.

Is there an open bug for this which I can put a cc: on? Thanks
(In reply to comment #2)
> (In reply to comment #0)
> Is there an open bug for this which I can put a cc: on? Thanks
I guess it is Bug216214 IM only supports AIM - request: support other IM tools
With trunk build (and I guess branch) version 1.6a1 (20050918), the presence
check still appears to happen. I guess the problem may be in:

http://lxr.mozilla.org/seamonkey/source/mail/components/addrbook/jar.mn

look at lines 2 and 22, abCardViewOverlay.js is preprocessed from
content/abCardViewOverlay.js on line 2 and then not processed from
/mailnews/addrbook/resources/content/abCardViewOverlay.js on line 22.

It looks like the second instance is overwriting the first. Therefore
Thunderbird is actually picking up the non-branched version of
abCardViewOverlay.js (I checked by unpacking my messenger.jar)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This patch fixes the problem with including the mailnews abCardViewOverlay.js
as opposed to the thunderbird one. The differences in the files are:

SeaMonkey currently checks for aim presence (we have a bug on that), whereas
the Thunderbird version does not.
SeaMonkey also uses openTopWin for opening URLs whereas the Thunderbird version
uses launchExternalURL from nsIMessenger.

So I think Thunderbird will want to pick up this change.

Scott if you want the patch in the 1.8 branch, please set/request approval.
Attachment #197285 - Flags: superreview?(mscott)
Attachment #197285 - Flags: review?(mscott)
Comment on attachment 197285 [details] [diff] [review]
Include the correct file in the build.

thanks mark.

lemme know if you need me to check this into the 1.8 branch.
Attachment #197285 - Flags: superreview?(mscott)
Attachment #197285 - Flags: superreview+
Attachment #197285 - Flags: review?(mscott)
Attachment #197285 - Flags: review+
Attachment #197285 - Flags: approval1.8b5+
Comment on attachment 197285 [details] [diff] [review]
Include the correct file in the build.

Checked into trunck & branch.
Status: REOPENED → RESOLVED
Closed: 19 years ago19 years ago
Resolution: --- → FIXED
Note: See Bug 309068 for Mailnews (SeaMonkey).
Keywords: fixed1.8
No longer blocks: 594081
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: