295764 - extensions removed in ffox 1.0.4 reappear in deer park

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[sairuh (rarely reading bugmail)]

Marcia and I see this on Mac OS X (panther and tiger) and Tracy sees this Windows.

1. start with a clean profile in ffox 1.0.4.

2. install an extension, eg, Web Developer 0.9.3 (from UMO).

3. quit and restart ffox 1.0.4 to ensure that Web Developer installed fine and
is active.

4. while still in ffox 1.0.4, go to the Extensions dialog.

5. select Web Developer and click the Uninstall button.

6. quit ffox 1.0.4.

7. start up deer park (200505270x-trunk).

results: if you open up Extensions in deer park, Web Developer is *still* there.
it won't be active in the UI, but that's covered by bug 286299. if you restart
deer park, then the Web Developer UI is back --which is wrong since I had
removed it in step 5 above.

8. if I quit deer park and restart ffox 1.0.4, the extension remains absent.

seems like we're not "cleanly" removing the extension.

Comment 1

[sairuh (rarely reading bugmail)]

this might be edge-case, because if I had restarted ffox 1.0.4 after step 6 but
before step 7, the extension is no longer listed in Extensions once we do start
deer park.

Comment 2

[Robert Strong (they/them - no direct email)]

The uninstall code for 1.0.4 has changed with the landing of the patch in bug
286034 so if you have a pending uninstall it will not be performed when you
launch 1.1a. I am fairly certain this won't affect pending disables, enables, or
installs mainly due to luck but I haven't verified this. This is IMO an edge
case and perhaps a release note would suffice.

Comment 3

[Benjamin Smedberg]

What Robert said; pending uninstalls will be ignored.