295770 - Should load Privacy policy asynchronously (or from a local resource)

Status: RESOLVED WONTFIX

(Other Applications Graveyard :: Reporter, defect)

Description

[Nickolay_Ponomarev]

Currently [Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050527 Firefox/1.0+] when you open Reporter using a slow connection,
there's a noticable lag (up to three seconds) before the window is shown. That's
because the remote resource, http://reporter.mozilla.org/privacy/ , is fetched
synchronously before the first page of wizard is shown.

Calling this code using setTimeout(., 0) solves the problem.
var privacyURL = getCharPref("privacyURL","http://reporter.mozilla.org/privacy/");
document.getElementById("privacyStatement").setAttribute("src",
privacyURL+"?plain");', 0);

Comment 1

[Robert Accettura [:raccettura]]

Attachment: Patch v1

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 237861 [details] [diff] [review]
Patch v1

Shouldn't the dontShowPrivacyStatement checkbox be disabled until the privacy policy loads (you can't accept a policy that hasn't loaded yet)? You should be able to do that by disabling it by default and then enabling it again after the call to setAttribute in the timeout.

Comment 3

[Robert Accettura [:raccettura]]

ok, lets do that... I'll upload a new patch in a minute or two.

Comment 4

[Robert Accettura [:raccettura]]

Attachment: Patch v2

Comment 5

[Robert Accettura [:raccettura]]

Attachment: Patch v2.1

Don't dynamically disable checkbox

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 237875 [details] [diff] [review]
Patch v2.1

r=me, assuming you've tested it, but I'd move the "var dontShowPrivacyStatement" to right above where it's needed, and I'd probably take the "var privacyURL = getCharPref" outside of the timeout.

Comment 7

[Nickolay_Ponomarev]

Was this patch forgotten?

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Reporter isn't a maintained project. Closing!