295855 - Abandoned default theme dir in the profile's extensions dir sets the default theme to disabled when upgrading to Deer Park

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

When upgrading from 1.0.x to DeerPark there is a default theme dir abandoned in
the profile's extensions directory with the previous app's default theme's
install.rdf. On first launch the new EM code attempts to install it and then
finds that it has an incompatible target app maxVersion. When the Themes Manager
is opened the default theme is not listed.

simple patch coming up.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

This patch checks for the existence of the abandoned theme dir and if it exists
it removes it. It does this in checkForMismatches only when an app version
change has been detected in order to avoid a perf impact. I tested this when
upgrading a 1.0.3 profile to a Deer Park profile and also tested using the
profile again with 1.0.3. I don't foresee any issues with using the profile
again witht 1.0.3 due to this change but if there were to be a problem with
this that is most likely where I believe it would be.

Comment 2

[Robert Strong (they/them - no direct email)]

With the checkin for bug 293419 instead of the default theme not showing at all
it now shows as disabled. Modifying summary accordingly and I think this is
going to be needed for 1.1a1.

Comment 3

[Caleb]

Comment on attachment 184794 [details] [diff] [review]
patch

Removing obsolete request and setting request for 1.1a2

Comment 4

[Mike Shaver (:shaver emeritus)]

Comment on attachment 184794 [details] [diff] [review]
patch

a=shaver for 1.1a2

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: same patch w/ updated comment

The only change in this patch from the previous one is the comment has been
updated to state that the default theme will be disabled since this behavior
changed with the checkin of the patch from bug 293419.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 184997 [details] [diff] [review]
same patch w/ updated comment

Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--
 nsExtensionManager.js.in
new revision: 1.111; previous revision: 1.110
done

Comment 7

[Robert Strong (they/them - no direct email)]

fixed on trunk

Comment 8

[Robert Strong (they/them - no direct email)]

*** Bug 297181 has been marked as a duplicate of this bug. ***