295888 - EM should not update to extension version that doesn't include current extension locale

Status: NEW

(Toolkit :: Add-ons Manager, enhancement, P5)

Description

[Jens Bannmann]

When users have an extension in, let's say, de-DE, they wouldn't want Firefox to
update to an en-US-only version without them being asked.

Basically, we'd need to transmit the currently selected locale for an item to
the update service, which would then need to provide us with either a matching
update or a "sorry, new release only supports xx-YY and ab-CD" info.

Dialog idea: "You are about to update to version 1.5 of "fooExt". This version
does not have the locale you're currently using, <locale>. Instead, the locale
<updateLocale> would be used. Would you like to proceed?" (by HB). If the user
says no, Firefox would remember it and no longer ask for this version. It would
continue checking, though, until a matching package is found.

Additionally/alternatively, there could be an "extensions.accept_locales pref,
set to just @ab_CD@ per default" (by Pike).

This bug is intended for discussion on how things should work exactly.

Comment 1

[Robert Kaiser]

well a German-only and an English-only extension should never have the same extension ID, I thought... So why exactly is this a problem?

Comment 2

[Dave Townsend [:mossop]]

(In reply to comment #1)
> well a German-only and an English-only extension should never have the same
> extension ID, I thought... So why exactly is this a problem?

You are making an assumption that the extension id changes when you change the locale set in the extension. This is certainly never going to always be the case.

Imagine I have an extension with 20 locales in it. I them do a major upgrade, for whatever reason my localiser for de-DE is unable to do the translation and I can't find anyone to do the translation. I'm not going to change my extension's id in this situation, I'm going to release without the locale.

Comment 3

[Robert Kaiser]

OK, this is a case that seems a good idea to warn about, yes.

Comment 5

[Nicolas Mandil (:NicolasWeb)]

This should block 565513, but I can't do it ;-)