295895 - can't unsubscribe from a calendar

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

You can't unsubscribe from a calendar.
I tried with context-menu, and then 'delete calendar'. That removed the first
item from the list, while i selected the second. But after a restart, it was back.
Question: should we still popup the dialog asking to also delete the file? It's
a bit dangerous, but if you delete your private calendar you should be able to
also delete the file (or the data from a bigger storage file)

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v1

Comment 2

[gekacheka]

Comment on attachment 184930 [details] [diff] [review]
patch v1

What is the expected result of this patch?  I was left with questions...

What is a calendar, and what does the delete operation supposed to do?	I
expected a calendar to correspond to a file, and deleting would remove the file
and its events from view.  It did remove its name from the list of calendars,
and that did persist over restart.

However, I expected that deleting a (local) calendar removes its events, but
they are still there, at least in the event list.  Their calendar name becomes
blank.	 If I add another calendar, they are given the name of that calendar. 
So it seems like another category column, not a file.

(A thought:  For local calendars, would it make sense to disallow deleting a
calendar if it is not empty?  That would make the user work harder to delete
events first, helping ensure they don't lose them accidentally.  But it may be
confusing if this behavior only affects local calendars and not remote ones. 
It is probably not a good idea to require the user 'deleting' events in someone
else's remote calendar they've subscribed to.)

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

The goal is to make it work a little better then currently. Without the patch,
you can't get rid of calendars once you subscribed to them. With the patch, you
can at least remove them from the calendars tab and the view. Deleting the data
still needs to be done.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v2 (UI behavior improvements, does not delete events)

This patch also removes the calendar from the composite calendar, so that the
events actually disappear from the views.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

(In reply to comment #2)
> (A thought:  For local calendars, would it make sense to disallow deleting a
> calendar if it is not empty?

Forcing the user to find all the events from the calendar isn't a good idea imo.
But we should at least add a confirmation dialog once we really start deleting
data. At the moment only the subscription is deleted, not the actual data. We
need to figure out how to do that, but for now i just want to be able to
unsubscribe.

Comment 6

[gekacheka]

Comment on attachment 184994 [details] [diff] [review]
patch v2 (UI behavior improvements, does not delete events)

The events reappeared for me on 20050526 + patch after a sequence like:
1. Add new calendar
2. add events to new calendar
3. resart
4. delete calendar
5. restart
6. add calendar
7. restart

However, I previously had a second calendar, so it may have been just restoring
the ability to access the second calendar, not creating a new one.

It looks like creating and deleting local calendars is broken in the backend,
because I cannot add a third calendar, and if I start with a fresh profile I
cannot add any additional calendars.

Error: [Exception... "'Failure' when calling method:
[calICalendarManager::registerCalendar]"  nsresult: "0x80004005
(NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://calendar/content/calendarCreation.js :: doCreateCalendar :: line 90" 
data: no]
Source File: chrome://calendar/content/calendarCreation.js
Line: 90

So I cannot review this until the other problems are fixed.

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 184994 [details] [diff] [review]
patch v2 (UI behavior improvements, does not delete events)

sure, there are problems left. This patch however also fixes a lot of prblems.
It is _not_ intended to delete data just yet. It only wants to get the calendar
out of the calendar list. nothing else. So yes, if you resubscribe to the
calendar, the events return. The subscribe problems you are seeing are covered
in bug 295990.

Comment 8

[gekacheka]

Comment on attachment 184994 [details] [diff] [review]
patch v2 (UI behavior improvements, does not delete events)

r=gekacheka for UI behavior improvements
(Sorry, I did't see your comments about the purpose earlier, only the bugmail
on the request.)

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in. Will file new bugs for actaully deleting events/files.