295916 - Throbber doesn't stop when document.write-ing text/plain content

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Build ID: 2005-05-29-05, Windows XP Seamonkey trunk.

Summary: Throbber doesn't stop when document.write-ing text/plain content

Clicking on most of the links found at
https://bugzilla.mozilla.org/attachment.cgi?id=184646 results in the
'busy/document loading' cursor, the progress meter, and sometimes the throbber
to be in an indeterminate state, as if the document hasn't finished loading.

[16:51] <biesi> bz,
http://lxr.mozilla.org/seamonkey/source/content/html/document/src/nsHTMLDocument.cpp#2104
[16:51] <bz> Yeah
[16:51] <biesi> bz, can that if there cause this?
[16:51] <bz> yes
[16:51] <bz> In fact it does

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: possible patch

maybe this? parser ignores writes that do not write any data. downside: adds a
space where none belongs...

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: real patch

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

oops.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 184829 [details] [diff] [review]
real patch

r=mrbkap

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 184829 [details] [diff] [review]
real patch

sr=bzbarsky

Comment 6

[Mike Shaver (:shaver emeritus)]

Comment on attachment 184829 [details] [diff] [review]
real patch

a=shaver

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in content/html/document/src/nsHTMLDocument.cpp;
/cvsroot/mozilla/content/html/document/src/nsHTMLDocument.cpp,v  <-- 
nsHTMLDocument.cpp
new revision: 3.604; previous revision: 3.603
done
Checking in parser/htmlparser/src/nsParser.cpp;
/cvsroot/mozilla/parser/htmlparser/src/nsParser.cpp,v  <--  nsParser.cpp
new revision: 3.365; previous revision: 3.364
done

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED by clicking on the links found here:

https://bugzilla.mozilla.org/attachment.cgi?id=184646

on Windows XP Seamonkey trunk build 2005-06-02-06.