295990 - can only create one storage (local) calendar using the wizard

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

The wizard uses moz-profile:// as url for a local storage calendar. It should
add ?id=<n> to be able to create multiple calendars.
Or should the storage calendar be more helpful? That would mean it changes the
url. Is that a good thing?

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This was supposed to be handled by the per-provider calICalendarProvider
service, or so I thought...

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Using a Windows debug build of Thunderbird, I get the following debug output
(starting from when I clicked the "New..." button to create a new calendar)

++WEBSHELL == 5
++DOMWINDOW == 5
asdad

moz-profile-calendar://
storage
*** Calendar schema version is: 3
registerCalendar: calendar already registered
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'Failure' when calling method: [calICalendarManager::registerCale
ndar]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome
://calendar/content/calendarCreation.js :: doCreateCalendar :: line 90"  data: n
o]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'Failure' when calling method: [calICalendarManager::registerCale
ndar]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome
://calendar/content/calendarCreation.js :: doCreateCalendar :: line 90"  data: n
o]
************************************************************

Comment 3

[Mike Shaver (:shaver emeritus)]

Taking, I have a small patch that fixed this without the need for all the
provider infrastructure, which will let us ship 0.8.

Comment 4

[Mike Shaver (:shaver emeritus)]

Attachment: Start at id=2, and find the first unallocated one in the list.

This causes some strange behaviour when you delete a calendar from the list and
then add a new one, because "delete" only unregisters.	It should
prompt-and-delete anyway (bug 298373).

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 186936 [details] [diff] [review]
Start at id=2, and find the first unallocated one in the list.

r=vladimir

Comment 6

[Mike Shaver (:shaver emeritus)]

FIXED, woo.