296016 - Help > Check for Updates can have "C" as the access key

Status: RESOLVED WONTFIX

(Firefox :: Menus, defect)

Description

[:deanis74]

There's nothing else to do after selecting the menu item before updates are
checked for, so there shouldn't be an ellipsis.

Comment 1

[Doron Rosenberg (IBM)]

Ben is rewriting the update stuff, please add that to his bug.

Comment 2

[:deanis74]

Changing this to encompass both cosmetic issues.

1. It shouldn't have an ellipsis, as originally reported.
2. The access key can be 'C' instead of 'o'.

Comment 3

[(no longer active)]

Attachment: Patch (v1)

Trivial patch...

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 296371 [details] [diff] [review]
Patch (v1)

>-<!ENTITY updateCmd.label                "Check for Updates…">
>+<!ENTITY updateCmd.label                "Check for Updates">

The ellipses are needed since the action launches a dialog in order to complete its operation, and if an update is found requires a choice from the user (apply now, apply later).

Comment 5

[(no longer active)]

(In reply to comment #4)
> (From update of attachment 296371 [details] [diff] [review])
> >-<!ENTITY updateCmd.label                "Check for Updates…">
> >+<!ENTITY updateCmd.label                "Check for Updates">
> 
> The ellipses are needed since the action launches a dialog in order to complete
> its operation, and if an update is found requires a choice from the user (apply
> now, apply later).

Morphing the bug to only include the access key related change...

Comment 6

[(no longer active)]

Attachment: Patch (v2)

Comment 7

[(no longer active)]

Attachment: Patch (v2)

Handle access key change only

Comment 8

[(no longer active)]

Comment on attachment 296394 [details] [diff] [review]
Patch (v2)

Oops, duplicate submission!

I thought Bugzilla caught all mid-air collisions...

Comment 9

[:deanis74]

(In reply to comment #4)
> The ellipses are needed since the action launches a dialog in order to complete
> its operation, and if an update is found requires a choice from the user (apply
> now, apply later).

Actually, no.  If the menu item said "Install Updates", then there is an action required.  But there is no further action to Check for Updates.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Beltzner: see comment 9.

Comment 11

[(no longer active)]

Beltzner, gavin: this needs r,ui-r to make it for the l10n freeze...

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 296395 [details] [diff] [review]
Patch (v2)

This doesn't need ui-review. You might try poking beltzner directly on IRC for a reply to comment 9.

Comment 13

[(no longer active)]

Note to drivers for approval: This is a minor change to correct an access key in the menus.  It would be nice to be able to land this before the l10n freeze.

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 296395 [details] [diff] [review]
Patch (v2)

a=beltzner for 1.9

Comment 15

[Vlado Valastiak [:wladow]]

Attachment: screenshot

Hey guys, you don't wanna do this, believe me ;). This accesskey is used for bunch of strings http://lxr.mozilla.org/mozilla/source/browser/locales/en-US/chrome/browser/browser.properties#65
adn those strings do not contain "c" char. Should be WONTFIX.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 296395 [details] [diff] [review]
Patch (v2)

Oh, right. Phooey, I forgot about that menu item's magical label switching. Should put a comment in the DTD file about it. Also, this bug sure has deviated from what comment #0 described!

Comment 17

[:Gavin Sharp [email: [e-mail]]]

Good catch, Vlado.

Comment 18

[(no longer active)]

WONTFIXing as per comment 15.  Thanks for the catch, Vlado!  :-)

Comment 19

[:Gavin Sharp [email: [e-mail]]]

I don't think it's very nice to have hijacked Dean's bug to turn it into an accesskey problem, and then mark it WONTFIX when that new problem is deemed invalid :) Now that the damage is done, a new bug should be filed to get an answer to comment 9, I suppose...

Comment 20

[(no longer active)]

(In reply to comment #19)
> I don't think it's very nice to have hijacked Dean's bug to turn it into an
> accesskey problem, and then mark it WONTFIX when that new problem is deemed
> invalid :) Now that the damage is done, a new bug should be filed to get an
> answer to comment 9, I suppose...

OK, you caught me red-handed  ;-)

-> bug 414182