296083 - [FIXr]{ib} Counter weirdness in block-in-inline situations

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 3247 comment 116 -- we seem to mess up when a counter is incremented on
a split inline.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

So I'm betting the problem here is that we add both of the inlines in the split
to the counter list and they both have a style context that has the
counter-increment on it.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

This is a bit of a hack, but I don't see a safe better way -- we need to init
the frames before we start setting them special, so InitAndRestoreFrame has no
obvious way to know that this frame shouldn't be getting counter stuff.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 188233 [details] [diff] [review]
Proposed fix

r+sr=dbaron, but in the long run I'd like to actually make this use
next/prev-in-flow linkage, and have a bit that indicates that the flow is
fixed.	This could solve a bunch of problems related to block-within-inline,
bidi continuations (nextBidi property), and :first-letter.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 188233 [details] [diff] [review]
Proposed fix

Requesting 1.8b3 approval.  This is also a very safe fix for a counter problem
that arises when a block is a child of an inline.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Agreed that using in-flow linkage for {ib} would simplify a bunch of stuff...

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed