296121 - Leak if document.open() is not followed by data

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Current trunk build

STEPS TO REPRODUCE:
1)  Start browser with leak logging.
2)  Type javascript:document.open() in the URL bar and hit enter (or just click
the link in the URL field of this bug).
3)  Quit

EXPECTED RESULTS: no leaks

ACTUAL RESULTS: leak

The reason is that we have a cycle document -> parser -> sink -> document for
HTML documents.  When we get to nsParser::Terminate, mParserContext is null, so
we null out the parser in the sink, but that doesn't break the cycle above, just
the sink/parser cycle.

Just nulling out mSink is also no good, since that will leave a non-null mParser
in the document and then when someone tries to document.write we'll end up
getting called and not having a sink.

Perhaps we should manually call DidBuildModel() on the sink in this case?

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: break the cycle

Yeah, this fixes the leak in the simplest way possible.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 184961 [details] [diff] [review]
break the cycle

This fixes a leak.

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 184961 [details] [diff] [review]
break the cycle

a=shaver

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked in.