296127 - [Mac] Options button systematically disappears

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Marcia Knous [:marcia]]

Seen using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2)
Gecko/20050531 Firefox/1.0+

STR: (existing profile, using default Firefox theme)

1. Go to extension manager, highlight and extension and click on the options
button (I had to click on it twice.)
2. Button disappears from the UI, but if you click in that general vicinity, it
does show the options.

Need to find the regression window on this one.

Comment 1

[Marcia Knous [:marcia]]

I just installed a different theme, and the button appears to work fine, so it
looks as if this is just an issue with the FF default theme.

Comment 2

[Steve England [:stevee]]

WFM Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050531
Firefox/1.0+ ID:2005053112

Comment 3

[Marcia Knous [:marcia]]

This probably is a Mac only bug - if someone can check Linux that would be
great, so we can rel note properly.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

This probably has to do with the Mac-only button down effect.

http://lxr.mozilla.org/mozilla/source/toolkit/themes/pinstripe/mozapps/extensions/extensions.css#103

Seems like the extensionOptions-pressed.png in my tree is a corrupted PNG.

Comment 5

[sairuh (rarely reading bugmail)]

yeah, I cannot repro this on linux (so far).

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Could anyone test this with a valid
classic.jar/skin/classic/mozapps/extensions/extensionOptions-pressed.png ?

For a cvs build, that image is at:
mozilla\toolkit\themes\pinstripe\mozapps\extensions\extensionOptions-pressed.png

CCing Stephen and Kevin, for the broken image.

Comment 7

[Robert Strong (they/them - no direct email)]

It looks like the options image was added to actionbuttons.png as it is for the
rest of the buttons but the css was never updated.

Comment 8

[Tracy Walker [:tracy]]

currently the button disappears on down click and reappears on release.  It fires the options dialog as 
expected.

Comment 9

[Robert Strong (they/them - no direct email)]

Attachment: patch

This changes the options button to use the options image in actionbuttons.png
since the images for the other buttons are already using these images and the
extensionOptions-pressed.png image is corrupt as previously noted. Tested on
Mac OS X and this WFM. I don't remove the extensionOptions.png and
extensionOptions-pressed.png with this patch.

Comment 10

[Doron Rosenberg (IBM)]

checked in.

Comment 11

[Tracy Walker [:tracy]]

Verified with Deer Park build on Mac 2005-07-01-07-trunk