296146 - Large SQL statement in editusers.cgi userDataToVars should be replaced with simple perl code.

Status: REOPENED

(Bugzilla :: Administration, task)

Description

[Max Kanat-Alexander]

> Looking at that particular part of the code, I think it should stay... I'm
> reluctant to give up optimized SELECTs for perl workarounds...

  Premature optimization is the root of all evil. Doing it the perl-based way
would be WAY less code, MUCH more modular, MUCH easier to maintain in the face
of schema changes, and would likely have no visible performance difference.

  My understanding is that you're trying to determine *where* a user's
permissions came from, whether they inherited them or have them naturally. You
could easily determine this by first retreiving ->groups and then retrieving
groups_direct (a method which may not exist, yet) and comparing them.

Comment 1

[Marc Schumann [:Wurblzap]]

I can't really say I'm working on this one right now...

Comment 2

[Frédéric Buclin]

No idea what you are talking about. Which part of the code? URL to LXR?

Comment 3

[Marc Schumann [:Wurblzap]]

Max is talking about the big SELECT in sub userDataToVars() of editusers.cgi the result of which is being put into $vars->{'permissions'}.

Comment 4

[David Lawrence [:dkl]]

No longer relevant in recent version of editusers.cgi.

Comment 5

[Frédéric Buclin]

(In reply to David Lawrence [:dkl] from comment #4)
> No longer relevant in recent version of editusers.cgi.

This code didn't change:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/webtools/bugzilla/editusers.cgi#738