Open Bug 296146 Opened 15 years ago Updated 6 years ago

Large SQL statement in editusers.cgi userDataToVars should be replaced with simple perl code.

Categories

(Bugzilla :: Administration, task)

2.19.3
task
Not set

Tracking

()

REOPENED

People

(Reporter: mkanat, Unassigned)

Details

> Looking at that particular part of the code, I think it should stay... I'm
> reluctant to give up optimized SELECTs for perl workarounds...

  Premature optimization is the root of all evil. Doing it the perl-based way
would be WAY less code, MUCH more modular, MUCH easier to maintain in the face
of schema changes, and would likely have no visible performance difference.

  My understanding is that you're trying to determine *where* a user's
permissions came from, whether they inherited them or have them naturally. You
could easily determine this by first retreiving ->groups and then retrieving
groups_direct (a method which may not exist, yet) and comparing them.
I can't really say I'm working on this one right now...
Assignee: wurblzap → nobody
No longer blocks: 283937
No idea what you are talking about. Which part of the code? URL to LXR?
Max is talking about the big SELECT in sub userDataToVars() of editusers.cgi the result of which is being put into $vars->{'permissions'}.
Assignee: nobody → administration
No longer relevant in recent version of editusers.cgi.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
(In reply to David Lawrence [:dkl] from comment #4)
> No longer relevant in recent version of editusers.cgi.

This code didn't change:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/webtools/bugzilla/editusers.cgi#738
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
You need to log in before you can comment on or make changes to this bug.