296158 - starwars.com - Popup windows incorrect width.

Status: RESOLVED INVALID

(Tech Evangelism Graveyard :: English US, defect)

Description

[neuropulse]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-GB; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-GB; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

All popup images in the Star Wars Databank are the incorrect width cutting off
the right side of the page.

Reproducible: Always

Steps to Reproduce:
1. Got to http://www.starwars.com/databank/organization/rebelalliance/index.html
2. Click on the image on the right under "STAR WARS PROFILE:"

Actual Results:  
A small window popped up with the right side of the page cut off.

Expected Results:  
The window should have been wider.

Comment 1

[dolphinling]

The page in question (actually, the window that's opened) uses this snippet of
script:

	if(is.ie) {	popImageWidth += 45;
		if(is.mac) { popImageWidth -= 10; }
	}
	else if(is.ns4) { popImageWidth	+= 35; }
	else if(is.ns7) { popImageWidth	+= 42; }
	else if(is.opera) {popImageWidth += 45; }

This checks for several browsers and adjusts the width differently for each, but
firefox is never checked for, so the width is never adjusted.

Everything we're doing is correct, so this bug would be invalid, but I'll send
it over to tech. evangelism.

Comment 2

[sjw]

STR doesn't fit anymore.
[closeme]