Closed Bug 296184 Opened 20 years ago Closed 20 years ago

Want a ITEM_FILTER_EVERYTHING for calICalendar.getItems

Categories

(Calendar :: Internal Components, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mvl, Assigned: shaver)

Details

Attachments

(1 file)

In order to get all the items from a calendar, you needs a filter like
calICalendar.ITEM_FILTER_TYPE_ALL | calICalendar.ITEM_FILTER_COMPLETED_ALL. And
if a filter is added, all callers need another _ALL filter.

Adding a ITEM_FILTER_EVERYTHING would help to make this more future-proof (and
keeps the calling code a few bytes shorter)
Attached patch Add ITEM_FILTER_ALL_ITEMS. — — Splinter Review
As requested.
Attachment #186092 - Flags: first-review?(mvl)
Comment on attachment 186092 [details] [diff] [review]
Add ITEM_FILTER_ALL_ITEMS.

Pretend CLASS_OCCURRENCES is 1 << 16 now, and that I can do math.
Comment on attachment 186092 [details] [diff] [review]
Add ITEM_FILTER_ALL_ITEMS.

Yeah, looks good.
Now we need to update the callers.
Attachment #186092 - Flags: first-review?(mvl) → first-review+
FIXED.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: