Closed
Bug 296261
Opened 20 years ago
Closed 20 years ago
nsIAccessible::GetPreviousSibling regression
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
Details
(Keywords: access)
Attachments
(1 file)
|
1.21 KB,
patch
|
parente
:
review+
neil
:
superreview+
chofmann
:
approval1.8b3+
|
Details | Diff | Splinter Review |
This is a major regression that went unnoticed for a while, because we have no testing that used GetPreviousSibling(). The screen readers that are working with us don't use it.
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #185050 -
Flags: review?(parente)
|
|
Assignee | |
Comment 2•20 years ago
|
||
Comment on attachment 185050 [details] [diff] [review] Fix loop to break when it should Note that I removed the if !mParent because it doesn't really optimize anything. GetParent() already uses mParent if it has been cached, so there is no need.
Attachment #185050 -
Flags: superreview?(neil.parkwaycc.co.uk)
|
||
Updated•20 years ago
|
Attachment #185050 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Attachment #185050 -
Flags: review?(parente) → review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #185050 -
Flags: approval1.8b3?
|
||
Comment 3•20 years ago
|
||
Comment on attachment 185050 [details] [diff] [review] Fix loop to break when it should a=chofmann
Attachment #185050 -
Flags: approval1.8b3? → approval1.8b3+
|
|
Assignee | |
Comment 4•20 years ago
|
||
Checking in accessible/src/base/nsAccessible.cpp; /cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v <-- nsAccessible.cpp new revision: 1.151; previous revision: 1.150 done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•