296267 - Merge code from contentAreaUtils.js and nsHelperAppDialog.js: makeFileUnique()

Status: RESOLVED WORKSFORME

(Toolkit :: Downloads API, defect)

Description

[(not currently active) Ted Mielczarek]

These two files have a block of identical code (and they mention each other in
the comment).
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/toolkit/content&command=DIFF_FRAMESET&file=contentAreaUtils.js&rev2=1.52&rev1=1.51
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/toolkit/mozapps/downloads/src&command=DIFF_FRAMESET&file=nsHelperAppDlg.js.in&rev2=1.25&rev1=1.24

We should make them share that code.

These changes were apparently made in bug 215194 and bug 215290

Comment 1

[Serge Gautherie (:sgautherie)]

<http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/content/contentAreaUtils.js&rev=1.102&mark=534#525>
<http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/mozapps/downloads/src/nsHelperAppDlg.js.in&rev=1.67&mark=309#299>

FWIW,
<http://mxr.mozilla.org/mozilla/search?string=makeFileUnique&case=on&tree=mozilla>

Comment 2

[(not currently active) Ted Mielczarek]

Looks like this got fixed along the way somewhere.