Closed
Bug 296284
Opened 19 years ago
Closed 19 years ago
<blockquote type=cite> can potentially confuse the plaintext serializer
Categories
(Core :: DOM: Serializers, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
(Keywords: regression)
Attachments
(1 file)
7.55 KB,
patch
|
peterv
:
review+
jst
:
superreview+
asa
:
approval1.8b3+
|
Details | Diff | Splinter Review |
In the patch for bug 144998, I noticed that there was a case where having: <blockquote type=cite>...</blockquote> <p>some stuff</p> <pre>more stuff</pre> could cause a newline to get removed between the <pre> and the <p>. I suspect there is a fairly simple fix (which I will try in a short while).
Assignee | ||
Comment 1•19 years ago
|
||
The example in comment 0 doesn't show this bug. I'm trying to find one that does.
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•19 years ago
|
||
The problem was that mHasWrittenCiteBlockquote was extending its effect even after it wasn't true, so we were munching up the newlines. There didn't seem to be a good place to put these tests (they aren't mailquote tests, per se) so I made a new file for testing random HTML (misc. html).
Attachment #185088 -
Flags: superreview?(jst)
Attachment #185088 -
Flags: review?(akkzilla)
Assignee | ||
Updated•19 years ago
|
Attachment #185088 -
Flags: review?(akkzilla) → review?(peterv)
Comment 3•19 years ago
|
||
Comment on attachment 185088 [details] [diff] [review] patch v1 sr=jst
Attachment #185088 -
Flags: superreview?(jst) → superreview+
Updated•19 years ago
|
Attachment #185088 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 4•19 years ago
|
||
Comment on attachment 185088 [details] [diff] [review] patch v1 This is a safe fix that fixes a small regression in the plaintext serializer.
Attachment #185088 -
Flags: approval1.8b3?
Updated•19 years ago
|
Attachment #185088 -
Flags: approval1.8b3? → approval1.8b3+
Assignee | ||
Comment 5•19 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Comment 6•19 years ago
|
||
I discovered a very similar problem. Take a look at http://forums.mozillazine.org/viewtopic.php?p=1583430 for a description of the problem.
You need to log in
before you can comment on or make changes to this bug.
Description
•