296289 - Fail to launch if bad path in extension

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[John Gaunt (redfive)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

I edited the helloworld test extensions and installed it. I missed two
references to the old app in the chrome/contents/<extension>/contents.rdf,
namely the location of the extensionOverlay.xul file. After closing down and
re-launching I would get an executable in my system monitor, but no UI would
ever show up. I _could_ get the profile manager to show, but never anything
beyond that. Even Safe-Mode didn't help. 

I hand edited the extension out and only after getting most of it out did I find
the offensive code. I created a new profile and attempted to install again,
hang. Cleaned up the extension, rezipped and installed, success.

This may be a deeper problem with the graceful degradation of reading RDF files,
but I'll let folks who understand the UI startup make that decision

Reproducible: Always

Steps to Reproduce:
1.Launch Firefox
2.Install "corrupted" extension (attachment to follow)
3.Close Firefox
4.Start Firefox

Actual Results:  
firefox.exe launched but never got past loading UI apparently. No UI was ever
displayed, but a 14MB application entry appeared in the system monitor.

Expected Results:  
Ideally it would be nice to output something to the javascript console stating a
bad RDF entry for an extensions while allowing the browser to start without the
extension installed. If there is _no_ notification it will make extension
development more difficult.

"Corrupted" extension will be attached in the bug.

Comment 1

[Peter van der Woude [:Peter6]]

well, where is the corrupted extension ?

Comment 2

[John Gaunt (redfive)]

Attachment: Extension with bad path in contents.rdf

Corrupt extension XPI

Comment 3

[John Gaunt (redfive)]

Marking WFM because now I can't get the hang to reproduce and the "expected"
behavior is happening, namely the app launches without the extension being
installed.

Comment 4

[John Gaunt (redfive)]

I'm going to test this again later, as I think the xpi I attached isn't
correctly corrupt.