296300 - Crash when minimizing window that has onfocus/onblur=window.close()

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase

- Press the button in the testcase, popup window should come up
- Click on the minimize button of the window

Result: crash

Comment 1

[Martijn Wargers (dead)]

Attachment: Testcase

Comment 2

[Martijn Wargers (dead)]

Attachment: backtrace from my debug build

Comment 3

[Martijn Wargers (dead)]

It looks like it is a regression, doesn't crash with 2004-05-03 build, crashes
with 2004-05-04 build:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-05-03+08%3A00%3A00&maxdate=2004-05-04+10%3A00%3A00&cvsroot=%2Fcvsroot

Comment 4

[Boris Zbarsky [:bzbarsky]]

This is a regression from bug 242111.  We now hold weak refs to focus
controllers across event dispatch in several places, so we're probably making
method calls on dead objects.  I'm not sure where it's safe to hold weak refs
here, though; my first instinct would be "nowhere where we dispatch an event or
set focus".

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix up one spot that crashes

There are probably others that need similar treatment...

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

I don't crash with build 2005-06-11-05 on Windows XP Seamonkey trunk.

Comment 7

[Mats Palmgren (inactive)]

Attachment: Testcase #2 (onfocus)

Same as the first testcase but uses 'onfocus' instead of 'onblur'.
Both testcases crashes Firefox on Windows XP, only the second (this) on Linux.

Comment 8

[Mats Palmgren (inactive)]

Attachment: Patch rev. 2

I found one more spot that needed fixing (for Testcase #2).
The remaining |focusController| pointers are very local and have no event
handling in their scope so they should be safe.

Comment 9

[Benjamin Smedberg]

No l10n impact, but we should really get this reviewed and landed.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 187311 [details] [diff] [review]
Patch rev. 2

r+sr=bzbarsky.	requesting 1.8b3 approval for this very very safe crash fix.

Comment 11

[Mats Palmgren (inactive)]

Checked in 2005-07-02 15:58 PDT

-> FIXED