296315 - nsIScrollable getScrollbarVisibility always returning true?

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

This testcase needs to be run locally (it's using enablePrivilege).
This getScrollbarVisibility is allways returning true/true for me, no matter if
the scrollbars are visible or not. Afaik, it should tell me if the
horizontal/vertical scrollbars on the page are visible or not.

This is what Boris had to say about it on IRC:
	bz	{#developers} mw22: I get true and false for horizontal/vertical
	bz	{#developers} mw22: with no scrollbars showing
	bz	{#developers} mw22: hmm
	bz	{#developers} mw22: file a bug, cc roc? ;)
	bz	{#developers} mw22: something is weird here.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase from the url attached here

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Well, there's no mystery about this one. It's not really implemented :-)

http://lxr.mozilla.org/mozilla/source/view/src/nsScrollPortView.cpp#331

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Simple stuff ...

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 186439 [details] [diff] [review]
fix

implements a DOM API. No risk to anyone not using the API, and since it
currently doesn't work at all, no risk there either.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in. Note that the testcase has "v" and "h" flipped, because for some
reason the docshell API takes the vertical status first. But that's the way it's
documented...

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

should view/public/nsIScrollableView.h get a new IID?

Comment 7

[Martijn Wargers (dead)]

(In reply to comment #5)
> checked in. Note that the testcase has "v" and "h" flipped, 
Oops! I didn't see that. I'm kind of used that horizontal comes first.
Thanks for the patch, Robert! I can use this for bug 212002 for instance.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to comment #6)
> should view/public/nsIScrollableView.h get a new IID?

Yeah, I guess.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I cleaned up many scrollbar-API-related things in bug 72747, but I missed this one.