Closed Bug 296315 Opened 19 years ago Closed 19 years ago

nsIScrollable getScrollbarVisibility always returning true?

Categories

(Core :: Layout, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: martijn.martijn, Assigned: roc)

References

()

Details

(Keywords: testcase)

Attachments

(2 files)

This testcase needs to be run locally (it's using enablePrivilege).
This getScrollbarVisibility is allways returning true/true for me, no matter if
the scrollbars are visible or not. Afaik, it should tell me if the
horizontal/vertical scrollbars on the page are visible or not.

This is what Boris had to say about it on IRC:
	bz	{#developers} mw22: I get true and false for horizontal/vertical
	bz	{#developers} mw22: with no scrollbars showing
	bz	{#developers} mw22: hmm
	bz	{#developers} mw22: file a bug, cc roc? ;)
	bz	{#developers} mw22: something is weird here.
Well, there's no mystery about this one. It's not really implemented :-)

http://lxr.mozilla.org/mozilla/source/view/src/nsScrollPortView.cpp#331
Attached patch fixSplinter Review
Simple stuff ...
Assignee: nobody → roc
Status: NEW → ASSIGNED
Attachment #186439 - Flags: superreview?(bzbarsky)
Attachment #186439 - Flags: review?(bzbarsky)
Attachment #186439 - Flags: superreview?(bzbarsky)
Attachment #186439 - Flags: superreview+
Attachment #186439 - Flags: review?(bzbarsky)
Attachment #186439 - Flags: review+
Comment on attachment 186439 [details] [diff] [review]
fix

implements a DOM API. No risk to anyone not using the API, and since it
currently doesn't work at all, no risk there either.
Attachment #186439 - Flags: approval1.8b3?
Attachment #186439 - Flags: approval1.8b3? → approval1.8b3+
checked in. Note that the testcase has "v" and "h" flipped, because for some
reason the docshell API takes the vertical status first. But that's the way it's
documented...
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
should view/public/nsIScrollableView.h get a new IID?
(In reply to comment #5)
> checked in. Note that the testcase has "v" and "h" flipped, 
Oops! I didn't see that. I'm kind of used that horizontal comes first.
Thanks for the patch, Robert! I can use this for bug 212002 for instance.

(In reply to comment #6)
> should view/public/nsIScrollableView.h get a new IID?

Yeah, I guess.
I cleaned up many scrollbar-API-related things in bug 72747, but I missed this one.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: