Closed Bug 296318 Opened 20 years ago Closed 20 years ago

rename calItemBase.parent to calItemBase.calendar

Categories

(Calendar :: Internal Components, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vlad, Assigned: vlad)

Details

Attachments

(2 files, 4 obsolete files)

The .parent name will shortly become pretty confusing; renaming it to .calendar
helps.

There are a few uses of .parent in this tree that the patch didn't change,
because they're not correct to begin with -- e.g. things that do
event.parent.someAttribute, where someAttribute isn't a valid.  With this patch
those things will generate a nice JS exception so they can be tracked down and
fixed to whatever they really should be.
Attached patch parent-calendar.patch β€” β€” Splinter Review
Attachment #185107 - Flags: second-review?(pavlov)
Attachment #185107 - Flags: first-review?(shaver)
Attachment #185107 - Flags: second-review?(pavlov) → second-review+
Attached patch ignore this (obsolete) β€” β€” Splinter Review
ignore this patch
Attached patch ignore this (obsolete) β€” β€” Splinter Review
Attachment #185212 - Attachment is obsolete: true
Attached patch test.patch (obsolete) β€” β€” Splinter Review
Attachment #185213 - Attachment is obsolete: true
Attached patch last try (obsolete) β€” β€” Splinter Review
Attachment #185216 - Attachment is obsolete: true
Attached patch more test β€” β€” Splinter Review
Attachment #185217 - Attachment is obsolete: true
Comment on attachment 185107 [details] [diff] [review]
parent-calendar.patch

r=shaver
Attachment #185107 - Flags: first-review?(shaver) → first-review+
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: