Closed
Bug 296318
Opened 20 years ago
Closed 20 years ago
rename calItemBase.parent to calItemBase.calendar
Categories
(Calendar :: Internal Components, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vlad, Assigned: vlad)
Details
Attachments
(2 files, 4 obsolete files)
|
12.75 KB,
patch
|
shaver
:
first-review+
pavlov
:
second-review+
|
Details | Diff | Splinter Review |
|
10.97 KB,
patch
|
Details | Diff | Splinter Review |
The .parent name will shortly become pretty confusing; renaming it to .calendar helps. There are a few uses of .parent in this tree that the patch didn't change, because they're not correct to begin with -- e.g. things that do event.parent.someAttribute, where someAttribute isn't a valid. With this patch those things will generate a nice JS exception so they can be tracked down and fixed to whatever they really should be.
| Assignee | ||
Comment 1•20 years ago
|
||
Attachment #185107 -
Flags: second-review?(pavlov)
Attachment #185107 -
Flags: first-review?(shaver)
Updated•20 years ago
|
Attachment #185107 -
Flags: second-review?(pavlov) → second-review+
| Assignee | ||
Comment 2•20 years ago
|
||
ignore this patch
| Assignee | ||
Comment 3•20 years ago
|
||
Attachment #185212 -
Attachment is obsolete: true
| Assignee | ||
Comment 4•20 years ago
|
||
Attachment #185213 -
Attachment is obsolete: true
| Assignee | ||
Comment 5•20 years ago
|
||
Attachment #185216 -
Attachment is obsolete: true
| Assignee | ||
Comment 6•20 years ago
|
||
Attachment #185217 -
Attachment is obsolete: true
Comment 7•20 years ago
|
||
Comment on attachment 185107 [details] [diff] [review] parent-calendar.patch r=shaver
Attachment #185107 -
Flags: first-review?(shaver) → first-review+
| Assignee | ||
Updated•20 years ago
|
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•