296335 - setting maxWidth, minWidth properties (from javascript) doesn't work

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Devon Jensen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050531 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050531 Firefox/1.0+

element.minWidth = 50;
or 
element.maxWidth = 50;
doesn't do anything

Reproducible: Always

Steps to Reproduce:

Comment 1

[Devon Jensen]

Attachment: Quick testcase

Comment 2

[Andrew Schultz]

confirmed with linux trunk 2005050601.  The bug started showing up between linux
trunk 2004091705 and 2004091806, so probably exposed by bug 296265

==> xul

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

What bug number did you mean?  That one doesn't seem right.

Comment 4

[Andrew Schultz]

right.  it was bug 253364

Comment 5

[Mike Schroepfer]

DBaron - can you take a look?

Comment 6

[Mike Schroepfer]

Blake - can you take a look since DBaron is currently out?

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: add (min|max)(Width|Height) to the MarkDirty path

It looks like this is exactly what we were doing before (simply calling
MarkDirty for these attributes) since we don't hit any of the inner
if-statements in this block.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 193478 [details] [diff] [review]
add (min|max)(Width|Height) to the MarkDirty path

Make those nice || line up with the rest of them, and r+sr=bzbarsky

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 193478 [details] [diff] [review]
add (min|max)(Width|Height) to the MarkDirty path

This is a safe fix to squish a regression.

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked in to MOZILLA_1_8_BRANCH and trunk.