Closed
Bug 296383
Opened 20 years ago
Closed 19 years ago
valueFromPreferences should report unknown pref types (eg 'char') to JS Console
Categories
(Toolkit :: Preferences, enhancement)
Toolkit
Preferences
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: asqueella, Assigned: asqueella)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
|
4.28 KB,
patch
|
mconnor
:
second-review+
|
Details | Diff | Splinter Review |
Currently <preference>'s valueFromPreferences getter and setter do nothing when they see an unknown value in preference's |type|. This is unhelpful: I accidentally used type="char" in my Options window, and spent a few minutes to find the problem -- it looked okay in the XUL file, and there were no messages in JS Console. It should instead report the error to the JavaScript Console, something like: "Preference [id] has unknown type [type]".
|
||
Updated•19 years ago
|
Version: unspecified → Trunk
|
Assignee | |
Comment 1•19 years ago
|
||
Assignee: nobody → asqueella
Status: NEW → ASSIGNED
Attachment #207972 -
Flags: second-review?(mconnor)
Attachment #207972 -
Flags: first-review?(bugs.mano)
|
||
Updated•19 years ago
|
Attachment #207972 -
Flags: second-review?(mconnor) → second-review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #207972 -
Flags: first-review?(bugs.mano)
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [checkin needed]
|
|
||
Comment 2•19 years ago
|
||
mozilla/toolkit/content/widgets/preferences.xml 1.53
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha1
You need to log in
before you can comment on or make changes to this bug.
Description
•