296390 - 'make xpi' fails

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

make xpi dies on:
cp libxpical/libxpical.so ./xpi/components
cp: cannot stat `libxpical/libxpical.so': No such file or directory

The filelist needs to be updated, because of all the new calFoo.js components.
OR even better, this should be done automaticly.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v1

This patch uses a xpi dir, which contains a modified copy of the lighting
Makefile.in, and packages everything into calendar.xpi. This way,
--enable-calendar still creates a build with calendar enabled without needing
extra steps to install it.
Tested on linux seamonkey.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 185149 [details] [diff] [review]
patch v1

The install.js in this patch is a copy of the existing install.js, with the
installation of the icons removed. That part is still broken.
The install.rdf that should be in the patch is a copy of the
calendar/install.rdf file. (something went wrong when creating the patch)

Comment 3

[Mostafa Hosseini]

Comment on attachment 185149 [details] [diff] [review]
patch v1

Finally, the correct way for building the xpi, well, almost.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in, leaving bug open for further cleanup, like removing the old
xpi targers in Makefile.in

Comment 5

[Worcester12345]

Is this bug the reason calendar extension is not being built as detailed in http://weblogs.mozillazine.org/calendar/2005/11/the_calendar_extensions_status.html
?

Perhaps someone can go to the Third Party Builds forum here http://forums.mozillazine.org/viewforum.php?f=42 and ask someone to try doing some calendar extension builds.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

(In reply to comment #5)
> Is this bug the reason calendar extension is not being built as detailed in
> http://weblogs.mozillazine.org/calendar/2005/11/the_calendar_extensions_status.html
> ?

No. Please read the entire bug before commenting (especially comment 4). Then read the blog entiry entry. It would answer your question.

Comment 7

[Peter Weilbacher]

Attachment: remove references to libxpical dir

I tried to make a calendar XPI from the trunk and it seems that the lines referring to the dir libxpical (that doesn't exist any more) in the Makefile are obsolete. At least I had to comment them to get "make xpi" to work fully.

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 206926 [details] [diff] [review]
remove references to libxpical dir

make xpi is obsolete. You need to make in the xpi dir.
There is no need to try to fix make xpi. We should just remove it.

Comment 9

[Peter Weilbacher]

Attachment: Redirect xpi target to xpi dir

OK, I don't usually work on Calendar and got confused (among other things) by the title of this bug. This new patch now removes all the XPI related stuff from calendar/Makefile.in and just redirects "make xpi" to call make in the xpi dir. (I hope I didn't delete too much.)

Comment 10

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 206934 [details] [diff] [review]
Redirect xpi target to xpi dir

>-ifndef MOZ_SUNBIRD
>-ifneq ($(OS_ARCH),Darwin)
>-DIRS += xpi
>-endif
>-endif

Just leave that part. Then there is no need for a seperate target to build the xpi. It will be built automaticly. (excpet when building sunbird, but then you don't need an xpi anyway)

Comment 11

[Peter Weilbacher]

Attachment: remove all xpi targets (but nothing else)

The idea behind removing that part was that if one builds with --enable-calendar one doesn't really need an XPI. But then package doesn't handle the calendar files so I agree that to build the XPI automatically makes more sense.

Comment 12

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 206943 [details] [diff] [review]
remove all xpi targets (but nothing else)

r=mvl

Comment 13

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in