296416 - method addPane should addchild to _paneDeck

Status: RESOLVED INVALID

(Toolkit :: Preferences, defect, P2)

Description

[Justin Wood (:Callek)]

the addPane method of prefwindow currently works incorrectly.

-this.appendChild(aPaneElement);
+this._paneDeck.appendChild(aPaneElement);

Patch forthcoming

Comment 1

[Justin Wood (:Callek)]

Attachment: Fix addPane

This is the fix described in c#0

Comment 2

[Justin Wood (:Callek)]

requesting blocking, incase the review/approval takes longer

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 185180 [details] [diff] [review]
Fix addPane

Ben, are you willing to review this patch, Neil seems to have been busy lately;
It is marked Blocking 1.8b4.

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 185180 [details] [diff] [review]
Fix addPane

No review from Neil, he has no (big/real) interest in FF widgets...

Seems I also had a misunderstanding here, this is not already broken behavior
(as in current method should still work).

I still imagine with this patch it would perform faster.

Comment 5

[Justin Wood (:Callek)]

<Callek> I imagine it would be faster [with addChild on the "real" anonymous
element]
<NeilAway> it depends on whether you want the appended element to be anonymous
<NeilAway> if you have <content><hbox><children/></hbox></content>
<NeilAway> if you appendChild to the hbox then the child appears to be at the
same place on the screen
<NeilAway> but obviously it has a different parent

This bug is actually Invalid, sorry for bugspam.

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 185180 [details] [diff] [review]
Fix addPane

clearing old review flag.