method addPane should addchild to _paneDeck

RESOLVED INVALID

Status

()

Toolkit
Preferences
P2
normal
RESOLVED INVALID
13 years ago
12 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

unspecified
mozilla1.8alpha6
Points:
---
Bug Flags:
blocking1.8b3 -
blocking1.8b5 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
the addPane method of prefwindow currently works incorrectly.

-this.appendChild(aPaneElement);
+this._paneDeck.appendChild(aPaneElement);

Patch forthcoming
(Assignee)

Updated

13 years ago
Assignee: nobody → bugspam.Callek
Priority: -- → P2
Hardware: PC → All
Target Milestone: --- → mozilla1.8alpha6
(Assignee)

Comment 1

13 years ago
Created attachment 185180 [details] [diff] [review]
Fix addPane

This is the fix described in c#0
Attachment #185180 - Flags: second-review?(neil.parkwaycc.co.uk)
Attachment #185180 - Flags: first-review?(neil.parkwaycc.co.uk)
(Assignee)

Comment 2

13 years ago
requesting blocking, incase the review/approval takes longer
Status: NEW → ASSIGNED
Flags: blocking1.8b3?

Updated

13 years ago
Flags: blocking1.8b4+
Flags: blocking1.8b3?
Flags: blocking1.8b3-
(Assignee)

Comment 3

13 years ago
Comment on attachment 185180 [details] [diff] [review]
Fix addPane

Ben, are you willing to review this patch, Neil seems to have been busy lately;
It is marked Blocking 1.8b4.
Attachment #185180 - Flags: first-review?(neil.parkwaycc.co.uk) → first-review?(bugs)
(Assignee)

Comment 4

13 years ago
Comment on attachment 185180 [details] [diff] [review]
Fix addPane

No review from Neil, he has no (big/real) interest in FF widgets...

Seems I also had a misunderstanding here, this is not already broken behavior
(as in current method should still work).

I still imagine with this patch it would perform faster.
Attachment #185180 - Flags: second-review?(neil.parkwaycc.co.uk)
(Assignee)

Updated

13 years ago
Severity: major → normal

Updated

13 years ago
Flags: blocking1.8b4+ → blocking1.8b4-
(Assignee)

Comment 5

13 years ago
<Callek> I imagine it would be faster [with addChild on the "real" anonymous
element]
<NeilAway> it depends on whether you want the appended element to be anonymous
<NeilAway> if you have <content><hbox><children/></hbox></content>
<NeilAway> if you appendChild to the hbox then the child appears to be at the
same place on the screen
<NeilAway> but obviously it has a different parent

This bug is actually Invalid, sorry for bugspam.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → INVALID
(Assignee)

Comment 6

12 years ago
Comment on attachment 185180 [details] [diff] [review]
Fix addPane

clearing old review flag.
Attachment #185180 - Flags: first-review?(bugs)
You need to log in before you can comment on or make changes to this bug.