the addPane method of prefwindow currently works incorrectly. -this.appendChild(aPaneElement); +this._paneDeck.appendChild(aPaneElement); Patch forthcoming
Assignee: nobody → bugspam.Callek
Priority: -- → P2
Hardware: PC → All
Target Milestone: --- → mozilla1.8alpha6
Created attachment 185180 [details] [diff] [review] Fix addPane This is the fix described in c#0
requesting blocking, incase the review/approval takes longer
Status: NEW → ASSIGNED
Comment on attachment 185180 [details] [diff] [review] Fix addPane Ben, are you willing to review this patch, Neil seems to have been busy lately; It is marked Blocking 1.8b4.
Attachment #185180 - Flags: first-review?(neil.parkwaycc.co.uk) → first-review?(bugs)
Comment on attachment 185180 [details] [diff] [review] Fix addPane No review from Neil, he has no (big/real) interest in FF widgets... Seems I also had a misunderstanding here, this is not already broken behavior (as in current method should still work). I still imagine with this patch it would perform faster.
<Callek> I imagine it would be faster [with addChild on the "real" anonymous element] <NeilAway> it depends on whether you want the appended element to be anonymous <NeilAway> if you have <content><hbox><children/></hbox></content> <NeilAway> if you appendChild to the hbox then the child appears to be at the same place on the screen <NeilAway> but obviously it has a different parent This bug is actually Invalid, sorry for bugspam.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → INVALID
Comment on attachment 185180 [details] [diff] [review] Fix addPane clearing old review flag.
Attachment #185180 - Flags: first-review?(bugs)
You need to log in before you can comment on or make changes to this bug.