296434 - showPane(null) makes prefwindow unusable

Status: VERIFIED DUPLICATE of bug 285513

(Toolkit :: Preferences, defect)

Description

[Nickolay_Ponomarev]

When you close the prefs window, the last selected pane's id is saved in
localstore.rdf. If you remove/rename that pane before reopening the prefs
window, you'll get absolutely broken window when you open it next time.

This happens because prefwindow's constructor doesn't check whether the pane
with saved id exists. It does something like this:

<...>
else if (this.lastSelected)
  paneToLoad = document.getElementById(this.lastSelected);
<...>
this.showPane(paneToLoad); // paneToLoad may be null!

So either the constructor should be fixed to handle this case, or (better imho)
showPane shouldn't break the prefwindow when it gets the null parameter.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Bug 285513 isn't in the right component, but I don't want to change it since
that will remove the flags.

*** This bug has been marked as a duplicate of 285513 ***

Comment 2

[Nickolay_Ponomarev]

didn't notice that.