296452 - Can create product with max votes per bug at 0, but then can't modify product

Status: RESOLVED DUPLICATE of bug 252214

(Bugzilla :: Administration, task)

Description

[A. Karl Kornel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax)

As per Bug 252214, an error occurs when a product has the "Maximum votes a
person can put on a single bug" field set to zero and the user tries to change
one of the other fields displayed when editing a bug (description, target
milestone URL, etc.).  The user will have to change the max. votes field to a
non-zero value to modify anything else on the page.

The interesting thing is you can actually add products where the "Maximum votes
a person can put on a single bug" field is set to zero, and Bugzilla won't complain.

Reproducible: Always

Steps to Reproduce:
1. Disable voting through editparams.cgi.
2. Create a new product, setting "Maximum votes a person can put on a single
bug" to zero.
3. Edit that product, modifying its description but leaving all other fields alone.

Actual Results:  
I received the error message "Sorry, the max votes per bug must be a positive
integer.".  In order to complete step 3, perform step 4:

4. Edit the product.  Set "Maximum votes a person can put on a single bug" to a
non-zero value.  Modify the description as was attempted in step 3.

Expected Results:  
The description should have been updated, without error messages.

The "Actual Results" is a manifestation of bug 252214.  However, that does not
necessarily mean that this is a duplicate.  Either it means that bug 252214 is
actually a bug (that zero should be a valid value when editing a product), or it
means that the zero value is actually invalid, and should have been caught at
the time the product was first added.

Comment 1

[A. Karl Kornel]

OK, I was just able to create a product with negative numbers in all of the vote-related fields.  That was 
also caught during an attempt to modify the product.  How much checking is performed on the vote-
related fields when a product is added?

Comment 2

[Frédéric Buclin]

You are correct! Tests are missing when creating a new product. I can reproduce
on both 2.18.1 and 2.19.3.

Comment 3

[A. Karl Kornel]

Quick question: Are the tests required the same as the tests performed when modifying a product's vote-
related fields?

Comment 4

[Frédéric Buclin]

(In reply to comment #3)
> Quick question: Are the tests required the same as the tests performed when
modifying a product's vote-related fields?

Yes! I'm fixing this right now. I should submit a patch very soon.

Comment 5

[Frédéric Buclin]

I don't want to bother with 2.18.1. Retargetting to 2.20.

Comment 6

[Frédéric Buclin]

Hum... I just realized that this bug is not fixed by bug 252214 which landed 4
days ago.

*** This bug has been marked as a duplicate of 252214 ***

Comment 7

[Frédéric Buclin]

*** This bug has been marked as a duplicate of 252214 ***