Closed Bug 296457 Opened 20 years ago Closed 20 years ago

reversed null check in DrawNativeSurfaces

Categories

(Core :: Graphics: Canvas2D, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ted, Assigned: Biesinger)

References

()

Details

Attachments

(1 file)

The check "if (tmpBuf) {" should be "if (!tmpBuf) {".  This prevents DrawWindow
from working.
Attached patch obvious patchSplinter Review
Assignee: nobody → cbiesinger
Status: NEW → ASSIGNED
Attachment #185208 - Flags: superreview?(bzbarsky)
Attachment #185208 - Flags: review?(bzbarsky)
Attachment #185208 - Flags: approval1.8b3?
Comment on attachment 185208 [details] [diff] [review]
obvious patch

a=chofmann
Attachment #185208 - Flags: approval1.8b3? → approval1.8b3+
Comment on attachment 185208 [details] [diff] [review]
obvious patch

r+sr=shaver
Attachment #185208 - Flags: superreview?(bzbarsky)
Attachment #185208 - Flags: superreview+
Attachment #185208 - Flags: review?(bzbarsky)
Attachment #185208 - Flags: review+
Checking in content/canvas/src/nsCanvasRenderingContext2D.cpp;
/cvsroot/mozilla/content/canvas/src/nsCanvasRenderingContext2D.cpp,v  <-- 
nsCanvasRenderingContext2D.cpp
new revision: 1.15; previous revision: 1.14
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: