296494 - crash [@ nsFileChannel::OnStartRequest ] when I call nsIChannel.asyncOpen()

Status: RESOLVED WORKSFORME

(Core :: Networking, defect)

Description

[alexander :surkov (:asurkov)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; ru-RU; rv:1.7.8) Gecko/20050511 Firefox/1.0.4 (ax)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; ru-RU; rv:1.7.8) Gecko/20050511 Firefox/1.0.4 (ax)

When I call asyncOpen(null, null) then mozilla is crashed.

Example:

var loadurl="file:///c:/mymodule.xml";
var requestor=new XMLHttpRequest();
requestor.open("GET", loadurl, false);
requestor.send(null);

requestor.channel.asyncOpen(null, null);

Reproducible: Always

Comment 1

[Steve England [:stevee]]

Does it crash with firefox 1.1alpha (deer park)
- http://www.mozilla.org/projects/deerpark/releases/alpha1.html

Did you submit any crash information? If so, what TalkbackIDs are they? (run
../components/talkback.exe to see the TBIDs)

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

> requestor.channel.asyncOpen(null, null);

you must not pass null as the listener. this bug seems invalid.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

(why are you using asyncOpen on a channel that is already opened? (by send))

(also, what do you _expect_ when you asyncOpen a channel without giving it a
listener?)

Comment 4

[alexander :surkov (:asurkov)]

Attachment: crash details

I post it like patch because file is too large.

Comment 5

[Darin Fisher]

you are using XMLHttpRequest incorrectly.  this bug is pretty much invalid
except that we probably still shouldn't crash ;-)

can you post a testcase?

Comment 6

[alexander :surkov (:asurkov)]

> you must not pass null as the listener. this bug seems invalid.
I think this bug cannot be invalid because this code crashes mozilla. It's
needed exception if such behaviour is not intended.

>also, what do you _expect_ when you asyncOpen a channel without giving it a
listener?
When I pass null instead of listener then I suppose I don't need any callback.
If you think it's wrong behaviour then throw exception.

>(why are you using asyncOpen on a channel that is already opened? (by send))

Actually I try to download file, change it and then upload it. There are missed
lines in code. But crash is presented with these lines or without them.

Comment 7

[alexander :surkov (:asurkov)]

Attachment: xml file

save it on root of 'c:' disc with name 'mymodule.xml'

Comment 8

[alexander :surkov (:asurkov)]

Attachment: test case

save this file and attached xml file on local disc

Comment 9

[Martijn Wargers (dead)]

Testcase crashes for me with:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20050821
Firefox/1.6a1
Talkback ID: TB8635856G

nsFileChannel::OnStartRequest 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/netwerk/protocol/file/src/nsFileChannel.cpp,
line 540]
0x778b0c24

Comment 10

[Ronald Tilby]

Testcase WFM using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060621 Minefield/3.0a1 ID:2006062104 [cairo]

Comment 11

[Martijn Wargers (dead)]

Yeah, testcase is wfm too, with current trunk build.

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

nsBaseChannel (bug 312760) fixed this
http://lxr.mozilla.org/seamonkey/source/netwerk/base/src/nsBaseChannel.cpp#470
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/netwerk/base/src/nsBaseChannel.cpp&rev=1.10&cvsroot=/cvsroot&mark=472#467

passing null to filechannel's asyncOpen should now throw NS_ERROR_INVALID_ARG