Closed Bug 296506 Opened 15 years ago Closed 15 years ago

[@ nsThread::Main]

Categories

(Core :: XPCOM, defect, critical)

x86
Windows XP
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

(Keywords: assertion, crash, memory-leak)

Crash Data

Attachments

(1 file, 1 obsolete file)

so, we're playing with threads.

and i noticed some failures to cleanup on failure (mlk).
i noticed some cases where the code gets upset if you call init twice (refusing 
to let you access thread.state and friends).
in testing the current codebase (after writing the patch i'm about to attach), 
i managed to crash nsThread::Main because one of 3 threads decided to null 
mRunnable before the last of three threads used mRunnable.
Attached file crash
init now allows secondary inits to result in threads whose state can be checked
Attachment #185257 - Flags: review?(dougt)
Attachment #185257 - Flags: review?(dougt) → review+
Attachment #185257 - Flags: approval1.8b3?
Attachment #185257 - Flags: approval1.8b3? → approval1.8b3+
Comment on attachment 185257 [details] [diff] [review]
change Init to handle alloc failures and refuse multiple concurrent runs of a thread instance

mozilla/xpcom/threads/nsThread.cpp	1.58
Attachment #185257 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Crash Signature: [@ nsThread::Main]
You need to log in before you can comment on or make changes to this bug.