Closed Bug 296522 Opened 20 years ago Closed 20 years ago

nsJAR.cpp uses wrong allocator

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.8beta3

People

(Reporter: Biesinger, Assigned: darin.moz)

Details

Attachments

(1 obsolete file)

References: <d7p757$54a1@ripley.netscape.com>

found by johnli1995@hotmail.com

DeleteManifestEntry uses PR_FREEIF, but the object was allocated using operator
new at http://lxr.mozilla.org/seamonkey/source/modules/libjar/nsJAR.cpp#670
(sorry for putting the bug in this component, but I can't find a better one)
Networking is probably the component I would have chosen as well :)
Keywords: helpwanted
This patch will fix the potential memory corrupt issue related with jar file
which is generated with netscape signtool. Firefox is easily to crash when
exposed in win98 with above scenario. It also occassionally observered in win2K
and winXP.
Attachment #185519 - Flags: review?(darin)
Attachment #185519 - Flags: review?(darin) → review+
Attachment #185519 - Flags: approval1.8b3?
Target Milestone: --- → mozilla1.8beta3
Attachment #185519 - Flags: approval1.8b3? → approval1.8b3+
Someone needs to check this in soon.
Whiteboard: [checkin needed]
fix checked in
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Keywords: helpwanted
Whiteboard: [checkin needed]
Attachment #185519 - Attachment description: match the allocator (new operator) and dealloator( delete) → match the allocator (new operator) and dealloator( delete) [Checked in: Comment 5]
Attachment #185519 - Attachment is obsolete: true
Verified FIXED using LXR/bonsai:

Rev	Author	Date		Log
1.118	db48x%yahoo.com	2005-06-14 03:29	 	bug 296522: nsJAR.cpp uses wrong
allocator patch by john 1995@hotmail.com"><johnli1995@hotmail.com>, r=darin, a=asa
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: