If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

From address in "Original Message" headers doesn't keep quotes when needed because of commas in name

NEW
Unassigned

Status

MailNews Core
Composition
--
minor
13 years ago
4 years ago

People

(Reporter: robzilla, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Reporter)

Description

13 years ago
I have an e-mail and the From address is:
     "User, Larry" <luser@example.com>

However, when I forward this message, the double quotes are removed when the
From address is written in the --- Original Message --- section.  E.g:

  -------- Original Message --------
  Subject:      blahbalah
  Resent-Date:  Wed, 01 Jun 2005 04:09:27 -0400
  Resent-From:  <support@example.com>
  Date:         Wed, 1 Jun 2005 04:09:27 -0400 (EDT)
  From:         User, Larry <luser@example.com>
  To:           Support <support@example.com>


This is annoying, because if I use this address when composing a new mail (by
copying and pasting), I don't get the double-quotes, and the ',' in the real
name gives me two addresses instead of one.

Comment 1

12 years ago
Reproduced with TB 1.0+0803, Moz 1.7.11.  I agree, it should maintain the 
quotes.
Assignee: mscott → nobody
Severity: normal → minor
Component: Message Compose Window → MailNews: Composition
OS: Windows XP → All
Product: Thunderbird → Core
Hardware: PC → All
Version: 1.0 → Trunk
QA Contact: composition
(Assignee)

Updated

9 years ago
Product: Core → MailNews Core

Updated

4 years ago
Summary: From address in "Original Message" headers doesn't keep quotes → From address in "Original Message" headers doesn't keep quotes when needed because of commas in name

Comment 2

4 years ago
Created attachment 8337414 [details] [diff] [review]
bug296529_fwd_quotes.patch

This fixes it for From, and other fields that happen to be a single addresses. 

Apparently http://mxr.mozilla.org/comm-central/source/mailnews/mime/public/nsIMsgHeaderParser.idl#135 preserveIntegrity doesn't actually work for a "line", just for a single address. If you have multiple comma separated addresses it still removes all the quotes
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #8337414 - Flags: review?(Pidgeot18)
I'm not sure I agree with this bug. The change to unquote these headers was done pretty explicitly in bug 189928 (it's for display, not for name). If the use case of copy-paste email addresses is to blame, then arguably the real fix is to improve the compose widgets for addressing to accept copy-paste of "display-ready" email addresses instead of relying on them already being in MIME format.

[Note that part 1 of bug 842632 already takes a hefty whack at the compose addressing widgets, so it would be wise to wait until that lands before tackling anything with addressing widgets in compose]

Comment 4

4 years ago
Well, we can only improve the input of a copy-pase is the the receiver is also a tb user. In the end, I'd just show the quotes and be done with it. Fortunately that kind of addresses seem to be very rare nowadays.
Comment on attachment 8337414 [details] [diff] [review]
bug296529_fwd_quotes.patch

Review of attachment 8337414 [details] [diff] [review]:
-----------------------------------------------------------------

I still disagree, but this patch is bitrotted anyways.
Attachment #8337414 - Flags: review?(Pidgeot18)

Comment 6

4 years ago
Especially for when you have multiple entries it sure is hard to parse without quotes. E.g.

Cc: Support <support@example.com>, User, Larry <luser@example.com>
Assignee: mkmelin+mozilla → nobody
Status: ASSIGNED → NEW

Updated

4 years ago
Attachment #8337414 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.